[Deps] Enable lmcache 0.5.4 with the kvaware router stack - #2
Closed
tyler2cr wants to merge 1 commit into
Closed
Conversation
Bumps the [lmcache] extra (lmcache 0.3.11 -> 0.5.4, vllm 0.13.0 -> 0.22.0), the kvaware router base image (2025-05-27-v1 -> v0.5.4), and the tutorial-17 engine image (v0.3.9post2 -> v0.5.4), with comments documenting WHY the pins must move in lockstep: the controller<->worker ZMQ messages are not a stable protocol across lmcache versions, and kv-aware chunk hashes are rooted in vLLM's NONE_HASH - a version mismatch on either axis makes every KV lookup miss silently. Router API surface verified against lmcache 0.5.4 (LMCacheControllerManager constructor, handle_orchestration_message, start_all, LookupMsg, QueryInstMsg - all unchanged, two new optional constructor params). Full router test suite passes (220/220). Signed-off-by: tyler <tcr@enfuse.io>
Owner
Author
|
Submitted upstream as vllm-project#1060 — that's now the canonical review venue; closing this staging PR. The branch stays available for interim image builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "enable the new version of lmcache with vllm-stack" change, as a standalone diff (3 files, +18/−5) — independent of the chat-tokenization PR (vllm-project#1045); mergeable in either order.
What it changes
[lmcache]extra:lmcache0.3.110.5.4(current stable)[lmcache]/[test]extras:vllm0.13.00.22.0docker/Dockerfile.kvawarebaselmcache/vllm-openai:2025-05-27-v1lmcache/vllm-openai:v0.5.4v0.3.9post2v0.5.4Each pin site now carries a comment documenting why the versions must move in lockstep — the two silent failure modes we hit on hardware:
RegisterMsgas "unknown message type," and the worker never registers — every KV lookup misses, routing degrades to session/QPS with no error.NONE_HASH— a router whose vllm differs from the engines' derives a different hash chain, and again every lookup silently misses.Verification
LMCacheControllerManagerconstructor (unchanged signature + two new optional params),handle_orchestration_message,start_all,LookupMsg,QueryInstMsg— all construct and behave.One heads-up for 0.5.4 adopters
lmcache 0.5.4 still defaults
lmcache_worker_heartbeat_time: None— workers never send heartbeats by default, while the controller reaps silent workers after ~30s, emptying the KV index shortly after startup ("misses that shouldn't be occurring"). The helm chart already mapslmcacheConfig.workerHeartbeatTime→LMCACHE_LMCACHE_WORKER_HEARTBEAT_TIMEand tutorial-17's values set it to"30", so chart-driven deployments are safe — but any hand-rolled engine config must set it explicitly.🤖 Generated with Claude Code