Prevent crash when the mark stack runs empty in DOMSerializer - #98
Open
artif-AndreasBrus wants to merge 1 commit into
Open
artif-AndreasBrus wants to merge 1 commit into
artif-AndreasBrus wants to merge 1 commit into
Conversation
closeMarkTags() pops the mark stack once per tag it has to close, but the stack can run empty before every tag is closed when marks are nested inconsistently -- e.g. a mark duplicated on a node that already inherits the same mark from a sibling. array_pop() then returns null and renderHTML() is called on null, raising a fatal error. Stop closing tags once the stack is empty instead. Adds a regression test covering a duplicated mark inherited from a sibling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closeMarkTags() pops the mark stack once per tag it has to close, but the stack can run empty before every tag is closed when marks are nested inconsistently -- e.g. a mark duplicated on a node that already inherits the same mark from a sibling. array_pop() then returns null and renderHTML() is called on null, raising a fatal error.
Stop closing tags once the stack is empty instead. Adds a regression test covering a duplicated mark inherited from a sibling.