Fix terminal contrast, protect edits and session identity, and stabilize refresh (0.0.45) - #156
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the version bump and xterm contrast configuration. No concrete correctness, compatibility, security, or performance issues found. LGTM.
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Reviewed the current 12-file diff, including the changes since the prior LGTM. The contrast/version changes remain clean, and the editor protection, refresh, search, rebuild, and session-association paths are otherwise consistent. One Kimi OAuth status regression remains: provider list cannot detect managed /login accounts.
💬 Posted 1 inline comment
- 💡 MEDIUM
src-tauri/src/lib.rs:2823This reports a valid Kimi OAuth login as unauthenticated: Kimi's managed OAuth account is intentionally omitted fromkimi provider list, so an account configured through/loginnever produces atype=line. Settings will therefore show “Not set up” and offer sign-in even though Kimi is authenticated. Query the CLI's managed-auth status/auth snapshot instead of using the provider list for this check.
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 3
Made with ❤️ by Ultralytics Actions
Since review 2, the Kimi authentication regression is addressed by the presence-only credential check and OAuth fallback handling. The remaining changes are otherwise consistent, but clearing a capped file search leaves a stale 10,000-entry warning visible; this is a bounded UI state bug.
💬 Posted 1 inline comment
- 📝 LOW
src/inspector.tsx:602When a search reaches the 10,000-entry cap,limitedis set totrue; clearing the query only stops expansion and aborts the walk, so the unconditional banner at lines 786–790 remains while browsing the tree normally. Resetlimitedwhen!lowered(or render the banner only while a query is active).
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 4
Made with ❤️ by Ultralytics Actions
Review 4: the stale file-search limit notice from review 3 is addressed, and the earlier Kimi authentication finding remains fixed. I found no new concrete correctness, security, data-loss, compatibility, or performance issues in the current diff. LGTM.
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock
|
🎉 Fantastic work getting PR #156 merged, @glenn-jocher!
This release brings that spirit to Lite with safer unsaved-work handling, more reliable Codex session association, bounded file search, and smoother Git, provider, refresh, and rebuild workflows. Thank you for the thoughtful improvements in Lite 0.0.45! |
Fix terminal contrast and the confirmed application audit findings in release 0.0.45. Codex input remains readable after a theme switch, file/session actions protect unsaved work, and refreshing Git no longer inserts a status row that shifts the cards.
Validation:
bun run check,bun test(20 tests),bun run build,cargo fmt --check, andcargo test(7 tests) pass locally.Browser fixtures use simulated native IPC; SSH script validation is local rather than an SSH end-to-end run. Save comparison detects pre-existing conflicts but does not lock out independent writers between comparison and replacement. Cross-platform compilation is covered by CI.
Hold merge for maintainer validation of the updated local Lite Dev 0.0.45 build.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Lite 0.0.45 improves terminal readability and protects unsaved work while stabilizing Codex session association, file search, Git refresh, provider status, and rebuild handling.
📊 Key Changes
🎯 Purpose & Impact
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock