Keep GitHub items under their requested repository and clear all warnings - #194
Conversation
… to 0.0.58 GitHub answers a renamed repository under its new name, so a candidate in one lost its group and skipped the 30-day activity check, and an explicit link in one showed twice. The item keeps the name it was asked by and takes only its kind from GitHub's answer.
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the GitHub item lookup changes and version bump. The returned URL preserves the queried repository and number while using GitHub’s typename for the item kind, fixing identity matching without an evident regression. LGTM.
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock
- Linux and Windows builds warned about the unused `app` in load_codex_server and an unneeded `mut` on the shell command: platform branches now use cfg! so each compiles everywhere. - Clippy: nested ifs become let-chains, and spawn_session takes its interface-decided fields as one camel-cased SessionLaunch instead of 22 arguments. - Vite's 500 kB web heuristic becomes a startup budget sized for a chunk Lite loads from disk. - CI allows Bun's install script, which newer npm otherwise warns it skipped.
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Since Review 1, the PR adds warning cleanup, groups the session launch payload under launch, and adjusts the CI install flag and Vite chunk budget. The GitHub identity fix remains intact, and the additional changes show no concrete behavioral regression. LGTM.
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock
|
Huge thanks to @glenn-jocher — this PR has been merged! Preserving the requested repository in GitHub lookups and updating the session-launch payload brings these parts of Lite’s workflow into alignment.
|
Follow-up to #193. GitHub's GraphQL API answers a renamed repository under its new name:
repository(owner: "zeit", name: "next.js") { issueOrPullRequest(number: 1) { url } }returnshttps://github.com/vercel/next.js/pull/1. Lite used that answered URL as the item's identity, so it no longer matched the reference that asked for it:likelyGitHubItemstreated it as a certain item. It was shown regardless of the 30-day activity check.mainalready did this for a Git remote that still uses an old name; Find GitHub items across wrapped rows and every session repository #193 extended it to every repository the session names.check_github_itemsnow builds the returned URL from the owner, repository and number it asked about, and takes only the kind (pullorissues) from GitHub's__typename. The GraphQL query stops asking forurl. GitHub still redirects the old name, and fixing the kind (a#Nasked as an issue that is a pull request) works as before. No TypeScript changes. Version 0.0.58.Validation
check_github_itemsagainst real GitHub:zeit/next.js/issues/1came back aszeit/next.js/pull/1(merged, last updated 2019), so the 30-day check now drops it as a candidate.ultralytics/lite/issues/193came back asultralytics/lite/pull/193.cargo fmt --checkandcargo testpass. Clippy reports no new warnings.bun run checkandbun test(32) pass.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
GitHub issue and pull-request lookups now retain the repository name Lite was asked about, while the session-launch payload and build configuration were also updated.
📊 Key Changes
__typenameto determine whether it is an issue or pull request.spawn_sessionnow receives session settings in a nestedlaunchobject, andApp.tsxsends that shape.🎯 Purpose & Impact
📋 Skipped 1 file (lock files, generated, images, etc.)
src-tauri/Cargo.lock