Repository navigation
Fix all compiler warnings, bugs, and deprecated API usage - #62
Merged
dwarakeshbaraneetharan merged 2 commits intoFeb 17, 2026
Merged
dwarakeshbaraneetharan merged 2 commits into
dwarakeshbaraneetharan merged 2 commits into
Conversation
…repo - Fix assignment (=) vs comparison (==) bug in manual_arm_joint_by_joint_controller - Zero-initialize can_frame structs in odrive_can_node to prevent UB - Remove unused variables (rmd, swerve_drive) and comment out unused params (rmd, double_ackermann, odrive_can) - Fix sign comparison warnings in smc_hardware_interface - Fix format string mismatch in stepper_hardware_interface - Update realtime_tools includes from deprecated .h to .hpp (6 headers) - Update parameter includes to namespaced form (6 headers) - Replace deprecated parameter_traits::OK/ERROR with tl::expected API (3 validation headers)
dwarakeshbaraneetharan
force-pushed
the
fix-build-warnings-errors
branch
2 times, most recently
from
February 17, 2026 14:07
4b40ba3 to
ea5f2c3
Compare
- Suppress unused parameter in CTRE Phoenix PigeonIMU_StickyFaults.h - Suppress unused parameter in ODrive can_simple_messages.hpp (Estop/DFU) - Remove unused joint_angle/joint_velocity in talon_hardware_interface.cpp - Remove -Wpedantic and fix jobserver warning in umdloop_can_library CMakeLists - Fix single_ackermann_controller.hpp includes to match main branch
dwarakeshbaraneetharan
force-pushed
the
fix-build-warnings-errors
branch
from
February 17, 2026 14:16
ea5f2c3 to
190a0fb
Compare
Collaborator
|
goated these errors always bothered me |
a-cires
pushed a commit
to a-cires/athena-code
that referenced
this pull request
Apr 13, 2026
* Fix all compiler warnings, bugs, and deprecated API usage across the repo - Fix assignment (=) vs comparison (==) bug in manual_arm_joint_by_joint_controller - Zero-initialize can_frame structs in odrive_can_node to prevent UB - Remove unused variables (rmd, swerve_drive) and comment out unused params (rmd, double_ackermann, odrive_can) - Fix sign comparison warnings in smc_hardware_interface - Fix format string mismatch in stepper_hardware_interface - Update realtime_tools includes from deprecated .h to .hpp (6 headers) - Update parameter includes to namespaced form (6 headers) - Replace deprecated parameter_traits::OK/ERROR with tl::expected API (3 validation headers) * Fix remaining third-party warnings and unused variables - Suppress unused parameter in CTRE Phoenix PigeonIMU_StickyFaults.h - Suppress unused parameter in ODrive can_simple_messages.hpp (Estop/DFU) - Remove unused joint_angle/joint_velocity in talon_hardware_interface.cpp - Remove -Wpedantic and fix jobserver warning in umdloop_can_library CMakeLists - Fix single_ackermann_controller.hpp includes to match main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
=) instead of comparison (==) inmanual_arm_joint_by_joint_controller.cppcan_framestructs inodrive_can_node.cppto prevent undefined behaviorstepper_hardware_interface.cppWarning fixes
rmd_hardware_interface.cpp,swerve_drive_controller.cpp,talon_hardware_interface.cpprmd_hardware_interface.cpp,double_ackermann_controller.cpp,odrive_can_node.cppsmc_hardware_interface.cppDeprecated API updates
realtime_toolsincludes from.hto.hpp(6 controller headers)generate_parameter_libraryincludes to namespaced form (6 controller headers)parameter_traits::OK/ERRORwithtl::expectedAPI (3 validation headers)