fix: prevent TypeError when verbose=True passed to arun()#1984
Open
kaixinhuzhu558-cyber wants to merge 1 commit into
Open
fix: prevent TypeError when verbose=True passed to arun()#1984kaixinhuzhu558-cyber wants to merge 1 commit into
kaixinhuzhu558-cyber wants to merge 1 commit into
Conversation
When calling arun(url, verbose=True), Crawl4AI raises TypeError
because 'verbose' is consumed by CrawlerRunConfig but still forwarded
through **kwargs.
Added kwargs.pop('verbose', None) to safely consume the parameter
before it reaches the downstream method.
Added tests/test_verbose_bug.py to verify no TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When calling \�run(url, verbose=True), Crawl4AI raises \TypeError: unexpected keyword argument 'verbose'\ because \�erbose\ is consumed by \CrawlerRunConfig\ but still forwarded through **kwargs.
Fix
Added \kwargs.pop('verbose', None)\ after line 254 in \�sync_webcrawler.py\ to safely consume the parameter before it reaches the downstream method.
Test
Added \ ests/test_verbose_bug.py\ that verifies \�run(url, verbose=True)\ no longer raises TypeError.