Skip to content

Fix patching of property subclasses - #27

Merged
OmeGak merged 1 commit into
masterfrom
fix-property-subclass
Nov 11, 2026
Merged

OmeGak merged 1 commit into
masterfrom
fix-property-subclass

Conversation

@OmeGak

@OmeGak OmeGak commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Patching a property subclass rebuilt the member as a plain property, so subclasses that override __get__ lost their type and behavior. In Indico this made patched @generated_data members vanish from IndicoForm.data, which selects them by isinstance. This build the new member with type(prop) as is already done for classproperty.

@OmeGak
OmeGak force-pushed the fix-property-subclass branch from 2c89bf0 to 9ea1187 Compare November 11, 2026 14:30
@OmeGak
OmeGak force-pushed the fix-property-subclass branch from 9ea1187 to 555c339 Compare November 11, 2026 14:38
@OmeGak
OmeGak merged commit c60937b into master Nov 11, 2026
@OmeGak
OmeGak deleted the fix-property-subclass branch November 11, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant