Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds ecosystem testing: a Node.js script builds and packs the local package, clones and patches an upstream consumer to use the local tarball, installs dependencies, and runs its build/tests. Adds an npm script, a GitHub Actions workflow, and updated tooling documentation. ChangesEcosystem Testing Pipeline
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pi0
changed the title
http-proxy-middleware
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ecosystem.yml:
- Around line 10-13: Replace floating action refs with full commit SHAs for each
uses: entry (e.g., actions/checkout, actions/setup-node) and set
persist-credentials: false on the actions/checkout step to avoid leaving tokens
in the workspace; update the checkout invocation that currently reads uses:
actions/checkout@v6 to use the repository@<full-sha> and add
persist-credentials: false, and similarly pin actions/setup-node@v6 and any
other actions (e.g., actions/checkout, actions/setup-node) to their full-length
commit SHAs to reduce supply-chain risk.
In `@AGENTS.md`:
- Line 174: AGENTS.md currently states that `pnpm build` runs `unbuild` but the
project uses `obuild`; update the AGENTS.md Build row to reflect the real
`build` script (mention `pnpm build` runs `obuild`) and describe the actual
output produced by `obuild` (CJS/ESM/types or whatever `obuild` emits) so the
doc matches the `package.json` `build` script; search for the Build table row
text (the line containing "pnpm build" / "unbuild") and replace it with the
correct command and artifact description.
In `@scripts/ecosystem-test.mjs`:
- Around line 63-66: The run helper currently builds shell-interpolated commands
and calls execSync (see run, execSync, ROOT, targetName), which allows shell
injection when variables like REF are interpolated into the command; replace
these execSync calls with an argument-based execution (e.g.,
child_process.spawnSync or execFileSync) passing the command and its arguments
as an array rather than a single shell string, ensure cwd and stdio: "inherit"
are preserved, and update the git clone/checkout usage (the block that
interpolates REF) to pass ["git", "clone", "--branch", REF, repo, dest] style
args (or validate/sanitize REF before use) so no shell parsing occurs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6f89e79c-1603-4463-a243-d22b91867462
📒 Files selected for processing (4)
.github/workflows/ecosystem.ymlAGENTS.mdpackage.jsonscripts/ecosystem-test.mjs
pi0
commented
May 20, 2026
| name: ecosystem | ||
| on: | ||
| push: | ||
| branches: [main, ci/hpm] |
Member
Author
There was a problem hiding this comment.
TODO
Suggested change
| branches: [main, ci/hpm] | |
| branches: [main] |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 8 8
Lines 791 791
Branches 325 325
=======================================
Hits 751 751
Misses 35 35
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pi0
commented
May 20, 2026
|
|
|
Hi @pi0 chimurai/http-proxy-middleware#1234 has been merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #141
add ecosystem test against https://github.com/chimurai/http-proxy-middleware
(wip: testing against chimurai/http-proxy-middleware#1234 branch until CI is green & seems
mockttprelated)/cc @chimurai
Summary by CodeRabbit
New Features
Documentation