fix: add rss+xml to textTypes, fix isJSONSerializable(null) - #617
Open
marceli1404 wants to merge 1 commit into
Open
fix: add rss+xml to textTypes, fix isJSONSerializable(null)#617marceli1404 wants to merge 1 commit into
marceli1404 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe utility updates mark ChangesUtility behavior
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#597 — RSS feeds with
application/rss+xml(andapplication/atom+xml) returned as Blob instead of text. Added both to thetextTypesset sodetectResponseTypereturns"text".#571 —
isJSONSerializable(null)threwCannot read properties of null (reading 'buffer')becausetypeof null === 'object', so null passed the type checks and crashed atvalue.buffer. Added an explicitvalue === nullguard returningtrue(null is JSON-serializable).Tests
All 28 existing tests pass.
Summary by CodeRabbit
nullvalues as JSON-serializable.