Skip to content

Date type handling code has problems #10

Description

@beastd

This seems not maintained anymore, but maybe this helps people noticing problems.

  • The date writing code, writes the timestamp with offset zero (UTC) and after that writes the current timezone offset.
  • The date reading code, reads the timestamp and then adds the stored offset and subtracts current timezone offset.

The reading code will lead to wrong results when the timezone written is different from the current timezone and if it's the same it will be a no-op.

Regarding the writing code, i guess it should maybe just write zero for the timezone. At least that is what I found written in the Adobe AMF 0 spec.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions