Prebuilt: drop the MiniMax-M3 and Inkling pins from the PR set - #43
Open
oobabooga wants to merge 1 commit into
Open
Prebuilt: drop the MiniMax-M3 and Inkling pins from the PR set#43oobabooga wants to merge 1 commit into
oobabooga wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops everything from
pr-set.jsonexcept DiffusionGemma, to get the nightly building again.The problem
The nightly full release build has been failing since b10152. The newest published release is still b10107-mix-1911198.
Upstream master now ships its own MiniMax-M3. The
unslothai#40branch carries a second copy of it, so the two collide and the merge step fails before anything is built.The change
Two entries come out.
ggml-org#24523(MiniMax-M3) is closed. The resolver already skips closed PRs, so this line has no effect today and is only cleanup.unslothai#40is the entry that actually breaks the build. It existed for one reason: to let ggml-org#24523 and Inkling sit in the set together, which they could not do otherwise. With ggml-org#24523 gone that job no longer exists, and the MiniMax-M3 half of the branch now duplicates what upstream ships.That leaves a single pin:
What this means for Inkling
ggml-org#25731was in the set only by way of #40, so it comes out as well.It cannot just be pinned on its own instead, because its current head does not merge onto master either. Putting it back needs a rebased branch, which is separate work, and pinning it as-is would leave the nightly red for a different reason.
Verification
Replayed on b10165: the one remaining pin merges cleanly, with no unmerged paths.
pr-set.jsonpasses the checks inunsloth-pr-set-lint.yml.