Prebuilt: repin on the rebased Kimi-K3 text PR and the fixed Inkling head - #49
Merged
Merged
Conversation
…head The nightly has been red since 2026-07-31. pwilkin force-pushed ggml-org#26185 at 21:16Z that day, eleven minutes before the schedule fired, and the pin in this file still named cf67f0d -- a merge commit that the rebase wrote out of the branch. The membership gate in the resolve step caught it and refused, so every build job was skipped. Runs 30666643530 and 30718507279 both died there. Two more things were wrong once that was unblocked: - Inkling was pinned to d69b7e6, which is the commit three separate reporters got garbage output from (CPU, Mac, and ROCm with -fa on). ggml-org#25731 fixed all of those in 02142bb; the nightly was shipping the broken one. - The rebase left ggml-org#26185 unmergeable against current master, and Kimi-K3 and Inkling register in the same arch, model and mtmd tables. Two independent heads cannot both land, so one of them has to know about the other. #48 now carries that. Its base branch was advanced to the rebased ggml-org#26185 head, then merged with b10223 and with Inkling, resolving four collisions: src/llama-arch.cpp KIMI_K3 and INKLING share a fallthrough src/llama-model.cpp same, in the ROPE_TYPE_NONE group tests/test-llama-archs.cpp master's MINIMAX_M3 vs KIMI_K3 tools/mtmd/ CMake source list and the graph registry All four are additive; both arches belong in every group. The two Kimi-K3 commits were rebased on top, so #48 is still a 10-file stacked diff against its base. ggml-org#26185 stays listed, last. Its head is now an ancestor of #48, so the resolver merges it as a no-op and the release manifest still names it. Verified against b10223: the four merge in this order with zero unmerged paths, and the merged tree builds with -DGGML_CUDA=ON. On the merged tree test-chat passes and test-llama-archs -a kimi-k3 is OK on both CUDA and CPU (NMSE 8.77e-08); it fails to even load the model without this repin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly prebuilt has been red since 2026-07-31. This repins
scripts/unsloth/pr-set.jsonso it resolves, merges and builds again.What broke
Resolve tagrefused and skipped every build job:pwilkin force-pushed
kimi-k3-textat 2026-07-31T21:16:01Z, eleven minutes before that night's schedule. The pin namedcf67f0d2, a merge commit the rebase wrote out of the branch, so the membership gate fired. Runs 30666643530 and 30718507279 both died there. The gate did its job.The set
c3fb972402142bbcd69b7e60daef2b3e04d6828bcf67f0d2Inkling was pinned to
d69b7e60, the commit three separate reporters got garbage output from: CPU, Mac, and ROCm/gfx1151 with-fa on(" the of France is the of France is"). ggml-org#25731 fixed those in02142bbc. The nightly was shipping the broken one, which is the more urgent half of this change.Kimi-K3 moves from #44 to #48. #44 was the everything-merged branch; #48 is the stacked pair of commits on top of ggml-org#26185, which is what we actually want to upstream.
Why ggml-org#26185 needed #48 to change
After the rebase, ggml-org#26185 does not merge onto current master, and Kimi-K3 and Inkling register in the same arch, model and mtmd tables. They cannot go in as two independent heads, so one has to know about the other.
kimi-k3-text-base(the base branch of #48) was advanced to the rebased ggml-org#26185 head, then merged withb10223and with Inkling02142bbc. Four collisions, all additive, both arches belonging in every group:src/llama-arch.cppLLM_ARCH_KIMI_K3vsLLM_ARCH_INKLINGin one fallthroughsrc/llama-model.cppLLAMA_ROPE_TYPE_NONEgrouptests/test-llama-archs.cppMINIMAX_M3vsKIMI_K3tools/mtmd/CMakeLists.txt,models/models.hThe two Kimi-K3 commits were rebased on top, so #48 is still a 10-file stacked diff against its base rather than a merge blob.
ggml-org#26185stays listed, and stays last. Its head is now an ancestor of #48, so the resolver merges it as a no-op and the release manifest still names it.Verification
Replayed the resolver's own merge sequence against
b10223:All four pins pass the resolve step's gate: open, membership OK, each at its PR head.
The merged tree builds clean with
-DGGML_CUDA=ON -DLLAMA_BUILD_TESTS=ON. On it:test-chatpassestest-llama-archs -a kimi-k3is OK on CUDA and CPU (NMSE 8.77e-08). On the old pin it could not even load the model:key not found in model: kimi-k3.expert_latent_lengthclip_graph_kimik3andclip_graph_inklinglink intolibmtmdOne note, not caused by this change:
test-llama-archsaborts onqwen3nexton the Meta backend, at a graph-split assert inggml-backend-meta.cpp. Pristineb10223aborts at the same assert, so it is an upstream issue, not ours.