fix(sdk): return typed errors for malformed JSON responses#2911
Open
iroiro147 wants to merge 1 commit into
Open
fix(sdk): return typed errors for malformed JSON responses#2911iroiro147 wants to merge 1 commit into
iroiro147 wants to merge 1 commit into
Conversation
Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context7Error@upstash/context7-sdkWhy
#2732 hardened the SDK's error-response path so response parsing could not leak a native
SyntaxError. The successfulapplication/jsonpath still calledres.json()without a guard, so an empty or malformed 200 response bypassed the SDK's typed error contract.This keeps parsing after the fetch retry loop: malformed response bodies fail once and are not retried.
Follow-up to #2732 and #1964.
Tests
vitest run src/http/index.test.ts(7 tests)git diff --check