fix(kiwi): convert SVG primitives to vector geometry - #692
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Sarankumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Someone is attempting to deploy a commit to the Notra Team on Vercel. A member of the Team first needs to authorize it. |
|
Do you have a before video to better grasp how this fixed the issue? |
|
Sorry, I don’t have a before-and-after video. I recently moved to a new Mac after losing my old laptop, along with my previous code and configs, so I’ve been setting everything up again from scratch. I also recently met with an accident and am still recovering, so I may not be able to reply or provide additional material for the next few days. Sorry for the inconvenience, and thanks for understanding. |
Description
Kiwi only imported SVG
pathelements, so logos and icons built fromcircle,rect,line,polyline,polygon, andellipsepasted into Figma incomplete. Primitive geometry is now converted to path data during DOM extraction, then reused by the existing vector-network pipeline, including fill/stroke inheritance.Screenshot/Recording (if applicable)
notra.figma.vector.mov
Checklist
Summary by cubic
Imports SVG primitives by converting them to path geometry during DOM extraction, so pasted SVGs with
circle,ellipse,rect,line,polyline, andpolygonimport completely. Previously onlypathwas imported; now primitives convert to path data and reuse the existing vector pipeline with inherited fill and stroke.SVG_GEOMETRY_SELECTORand converts each element viasvgPrimitiveToSubpaths.circle/ellipsevia arc commands;rectsupportsrx/ry;linebecomes a two-point open path;polylineis open;polygonis closed; invalid or zero-size primitives are ignored.SvgPrimitiveAttrsandsvgPrimitiveToPathData; tests cover each primitive for closure, bbox, and points. No API or data model changes.Written for commit 35c3254. Summary will update on new commits.