-
-
Notifications
You must be signed in to change notification settings - Fork 355
fix: Fix controller focus not being acquired on screen entry #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VinceBT
wants to merge
4
commits into
utkarshdalal:master
Choose a base branch
from
VinceBT:feature/initial-focus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0fb3312
fix: request initial focus on screen entry for controller nav
VinceBT 3462653
Address review feedback: retry username focus, key focus effect on re…
VinceBT d523a8e
Retry initial focus until requestFocus actually succeeds
VinceBT 289ff51
Request initial focus on game detail and 2FA screens with retry
VinceBT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -616,6 +616,18 @@ private fun CredentialsForm( | |
| val passwordFocusRequester = remember { FocusRequester() } | ||
| val usernameFocusRequester = remember { FocusRequester() } | ||
|
|
||
| // Focus the username field on entry so the first controller/D-pad press is not wasted. | ||
| // Retry: the field may not be attached on the first frame. | ||
| LaunchedEffect(Unit) { | ||
| repeat(5) { | ||
| try { | ||
| if (usernameFocusRequester.requestFocus()) return@LaunchedEffect | ||
| } catch (_: IllegalStateException) { | ||
| } | ||
| delay(32) | ||
| } | ||
| } | ||
|
Comment on lines
+621
to
+629
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this seems problematic - it'll bring up the keyboard on opening this screen, which will cover the QR code and isn't what we'd want by default. |
||
|
|
||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| Column( | ||
| modifier = Modifier | ||
| .fillMaxWidth(), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
app/src/main/java/app/gamenative/ui/util/FocusModifiers.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package app.gamenative.ui.util | ||
|
|
||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.LaunchedEffect | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.focus.FocusRequester | ||
| import androidx.compose.ui.focus.focusRequester | ||
| import kotlinx.coroutines.delay | ||
|
|
||
| /** | ||
| * Attaches [focusRequester] and requests focus once laid out, so a freshly opened screen already | ||
| * has a focused element. Apply BEFORE `.focusable()`/`.selectable()`/`.clickable()`. | ||
| * | ||
| * [enabled] gates the request; focus is (re)requested each time it becomes `true`. | ||
| */ | ||
| @Composable | ||
| fun Modifier.requestInitialFocus( | ||
| focusRequester: FocusRequester, | ||
| enabled: Boolean = true, | ||
| ): Modifier { | ||
| LaunchedEffect(focusRequester, enabled) { | ||
|
VinceBT marked this conversation as resolved.
|
||
| if (!enabled) return@LaunchedEffect | ||
| // Node may not be placed on the first frame, and requestFocus() returns false when the | ||
| // request is not honored yet; retry until it actually takes. | ||
| repeat(5) { | ||
| try { | ||
| if (focusRequester.requestFocus()) return@LaunchedEffect | ||
| } catch (_: IllegalStateException) { | ||
| } | ||
| delay(32) | ||
| } | ||
| } | ||
| return this.focusRequester(focusRequester) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.