yes: no hang with fcntl failure#12254
Open
oech3 wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
6d4eded to
86c0a0d
Compare
Contributor
|
Why do we call |
xtqqczze
reviewed
May 12, 2026
This comment was marked as resolved.
This comment was marked as resolved.
xtqqczze
approved these changes
May 12, 2026
Contributor
Author
|
Is |
Contributor
|
It is documented that |
oech3
commented
May 13, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't hang with
strace -o /dev/null -e inject=fcntl:error=ENOSYS yesby checking pipe size. The error does not appear on the daily usage. But it should be avoided.It was accidentally avoided by incorrect assumption for stdout.This bypasses
File::fromofuucore::pipes::pipe. So useRawWriterto allow usingwrite_all.Checking pipe size is not required for other splice(2)ing utils.