Skip to content

tee: merge flush into write for simplicity#12263

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:tee-flush
Open

tee: merge flush into write for simplicity#12263
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:tee-flush

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 12, 2026

reop #12089, but use the name write_all for the feature change.

@oech3 oech3 marked this pull request as ready for review May 12, 2026 16:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@RenjiSann
Copy link
Copy Markdown
Collaborator

Not convinced by this.
At least rename the function write_all_and_flush so we don't mistake the function for an implementation of trait Write

Comment thread src/uu/tee/src/tee.rs Outdated
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 13, 2026

This is needed to reduce diff by #12131 with the name write_all. RawStdout or something can be used instead.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 13, 2026

(I'm not sure what PR should rename Stdout to RawStdout...)

@oech3 oech3 requested a review from RenjiSann May 13, 2026 12:27
Comment thread src/uu/tee/src/tee.rs Outdated
@xtqqczze
Copy link
Copy Markdown
Contributor

This is needed to reduce diff by #12131 with the name write_all. RawStdout or something can be used instead.

To be honest, you could just propose the changes in #12263, rather than splitting the conversation.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 13, 2026

What do you mean? Did you mention incorrect hash?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants