-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
dd: enable WASI support for StdinFile on nightly #12264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ doctest | |
| # * crates | ||
| aho-corasick | ||
| blake2b_simd | ||
| rsconf | ||
| rustix | ||
|
|
||
| # * uutils project | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||||||||||||||
| // This file is part of the uutils coreutils package. | ||||||||||||||||||
| // | ||||||||||||||||||
| // For the full copyright and license information, please view the LICENSE | ||||||||||||||||||
| // file that was distributed with this source code. | ||||||||||||||||||
|
|
||||||||||||||||||
| fn main() { | ||||||||||||||||||
| let is_nightly = | ||||||||||||||||||
| rustc_version::version_meta().unwrap().channel == rustc_version::Channel::Nightly; | ||||||||||||||||||
| rsconf::declare_cfg("nightly", is_nightly); | ||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no way to detect whether a certain unstable feature is enabled; we have to check for nightly compiler. So
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just manually catching?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know, I'm open to suggestions.
Comment on lines
+7
to
+9
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I guess we can lose the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. Because we can reduce build time. |
||||||||||||||||||
| } | ||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasi-ext is not yet stabilised, we need to detect if we are compiling with nightly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use cfg_aliases to avoid new dep?