uudoc: add missing dependencies for all-features builds#546
Merged
Conversation
The uudoc binary imports zip and uuhelp_parser when the uudoc feature is enabled, but the root package did not declare those dependencies. This broke all-features builds and clippy checks. Declare the dependencies behind the uudoc feature so the documentation binary can be checked reliably without adding them to the default build. Signed-off-by: favilances <favilances@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing direct dependencies used by the
uudocbinary and wires them to theuudocfeature.Motivation
cargo clippy --all-targets --all-featuresfailed becausesrc/bin/uudoc.rsimportszipanduuhelp_parser, but the root package did not declare them. Declaring these dependencies behind the feature keeps the default build unchanged while making all-features checks reliable.Testing
cargo check --features uudoccargo fmt --checkcargo clippy --all-targets --all-featurescargo test