Skip to content

feat: add shareDriver, isReuseDriver hook, SPA navigation and headed mode to AbstractComponentIT #9255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
manolo wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: add shareDriver, isReuseDriver hook, SPA navigation and headed mode to AbstractComponentIT #9255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c28f672
feat: add isReuseDriver() hook, cross-class driver reuse, and SPA nav…
manolo May 9, 2026
346ad71
ci: forkCount=1 testsInParallel=1 to isolate shareDriver benefit
manolo May 9, 2026
18d8ff9
ci: switch to reuseDriver for comparison with forkCount=1
manolo May 9, 2026
daa89e8
ci: use shareDriver + useSpa with forkCount=4, drop no-op testsInPara…
manolo May 10, 2026
2047fb2
ci: remove useSpa, reduce MAX_SHARDS from 10 to 8
manolo May 10, 2026
5cd6a33
ci: 8 shards + reuseDriver for comparison against shareDriver
manolo May 10, 2026
d1cddc7
ci: add useSpa to 8 shards reuseDriver
manolo May 10, 2026
ad3518f
ci: back to 10 shards, reuseDriver + useSpa
manolo May 10, 2026
32f0a4b
ci: 8 shards + reuseDriver + useSpa as benchmark configuration
manolo May 10, 2026
e0b0494
ci: remove useSpa - causes Vaadin session state leakage between tests
manolo May 10, 2026
f388b33
fix: pass full relative URL (path+query) to SPA navigation
manolo May 10, 2026
2cc66b9
ci: remove useSpa - session event leakage between tests
manolo May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ jobs:
env:
SHARDS: ${{ github.event.inputs.shards || '0' }}
TARGET_PER_SHARD: 35
MAX_SHARDS: 10
MAX_SHARDS: 8
run: |
mapfile -t its < <(find integration-tests/src/test/java -name '*IT.java' -printf '%P\n' | sed -e 's|/|.|g' -e 's|\.java$||' | sort)
count=${#its[@]}
Expand Down Expand Up @@ -489,7 +489,6 @@ jobs:
-Dvaadin.productionMode \
-DskipFrontend \
-Dfailsafe.forkCount=$FORK_COUNT \
-Dcom.vaadin.testbench.Parameters.testsInParallel=2 \
-Dfailsafe.rerunFailingTestsCount=2 \
-Dmaven.test.redirectTestOutputToFile=true \
-Dtest.reuseDriver=true \
Expand Down
Loading
Loading