Skip to content

fix/ESO upgrade#123

Open
day0hero wants to merge 13 commits into
validatedpatterns:mainfrom
day0hero:fix/ESO_upgrade
Open

fix/ESO upgrade#123
day0hero wants to merge 13 commits into
validatedpatterns:mainfrom
day0hero:fix/ESO_upgrade

Conversation

@day0hero
Copy link
Copy Markdown
Contributor

  • Repo/ESO Updates
  • update to values-group-one.yaml

@sabre1041
Copy link
Copy Markdown
Collaborator

@day0hero With the integration of #99 , there are some impacts on your PR. Would you be able to review the latest changes and make the required modifications to resolve the conflicts

Comment thread charts/qtodo/values.yaml Outdated
Comment thread values-global.yaml Outdated
Comment thread common/scripts/determine-main-clustergroup.sh Outdated
Comment thread common/Makefile Outdated
Comment thread Makefile
day0hero added a commit to day0hero/layered-zero-trust that referenced this pull request Apr 27, 2026
- in response to validatedpatterns#123 - where we need to figure out better long term
  approaches for modernizing the repo structure.
- this commit modifies just the values-hub.yaml and the ESO manifests
  within the repository to use openshift-external-secrets-operator
day0hero added 9 commits June 2, 2026 09:43
- ran patternizer against the repo to ensure that the latest goodness is
  from the vp framework is applied.
- updated ESO from upstream to openshift supported
- updated values-hub to use `argoProject{,s}`
- changed namespace definition from list to dictionary. this is
  currently required for the framework to support multiple versions of
an operator/service (golang-external-secrets/openshift-external-secrets)
day0hero added 2 commits June 2, 2026 13:26
- changed job behavior to match rhtpa-ingress-ca-extractor chart
- central-htpasswd is now operator-managed
Copy link
Copy Markdown
Collaborator

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comment.

Comment thread scripts/gen-byo-container-registry-variants.py
Copy link
Copy Markdown
Collaborator

@mlorenzofr mlorenzofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to correct the conflicts in the values-hub.yaml file (remove the policies and jwt configuration blocks) and add an new policy

Comment thread overrides/values-vault-jwt.yaml
day0hero and others added 2 commits June 4, 2026 13:36
added policy

Co-authored-by: Manuel Lorenzo <mlorenzofr@gmail.com>
@day0hero
Copy link
Copy Markdown
Contributor Author

day0hero commented Jun 4, 2026

@mlorenzofr - everything should be resolved now. please confirm

@day0hero day0hero requested a review from mlorenzofr June 4, 2026 12:59
Copy link
Copy Markdown
Collaborator

@mlorenzofr mlorenzofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are working well, but we need other changes to complete the transition.

  1. Merge validatedpatterns/rhbk-chart#7 so that the RHBK chart uses the correct API version in the ExternalSecrets
  2. Make a small refactor in scripts/gen-feature-variants.py to address some changes related to data types and the location of JWT roles. I'll do this in another PR, I almost have the changes ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants