Repository navigation
Conversation
5 of 7 tasks
This was referenced Oct 26, 2026
Aryex
force-pushed
the
refactor/organize-command-files
branch
from
October 30, 2026 18:06
f310f85 to
8c65b11
Compare
Aryex
force-pushed
the
refactor/organize-command-files
branch
from
October 30, 2026 18:22
8c65b11 to
27f03de
Compare
Aryex
marked this pull request as ready for review
October 30, 2026 18:34
Signed-off-by: Alex Le <alex.le@improving.com>
Aryex
force-pushed
the
refactor/organize-command-files
branch
from
October 30, 2026 21:35
27f03de to
dde25d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the PubSub code from
glidemodule topubsubmodule, making it inline with how search module works.Issue link
No linked issue. This is a focused organization change for the existing Pub/Sub implementation.
Changes
Pub/Sub files are now organized as:
require "valkey/pubsub"loads the Pub/Sub types and internal receiver without requiring the main client entrypoint. Tests andAGENTS.mdnow use the new namespace and paths.Test also moved to reflect the new location.
Limitations
This PR only reorganizes Pub/Sub support. Search commands and types are unchanged.
Testing
bundle exec rake test:unit(528 tests, 1,371 assertions, 0 failures)bundle exec rubocop(141 files, no offenses)require "valkey/pubsub"check usingValkey::PubSub::PubSubMessage,PubSubState, andPubSubReceiverChecklist
Before submitting the PR make sure the following are checked:
git commit -s) per the DCO.AGENTS.mdis updated.bundle exec rubocop) and pass.