Repository navigation
fix(ruby): require TLS for IAM auth - #397
Merged
Merged
Conversation
jeremyprime
force-pushed
the
enforce-tls-iam-auth
branch
from
October 26, 2026 18:55
9d16580 to
bc7a190
Compare
Aryex
self-requested a review
October 26, 2026 21:40
Aryex
requested changes
Oct 27, 2026
Aryex
left a comment
Collaborator
There was a problem hiding this comment.
Since TLS + IAM validation sits at the core I assume that is tested already?
Other than that, just some cleanup for comments.
Collaborator
Author
Yes, the TLS guard is in the core and there are tests at that level to verify it works. |
Aryex
approved these changes
Oct 27, 2026
yipin-chen
approved these changes
Oct 28, 2026
jeremyprime
force-pushed
the
enforce-tls-iam-auth
branch
from
October 28, 2026 18:26
9c35530 to
0d43904
Compare
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
jeremyprime
force-pushed
the
enforce-tls-iam-auth
branch
from
October 28, 2026 18:37
0d43904 to
da52220
Compare
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An IAM authentication token is a bearer credential. Sending it over a plaintext connection lets a network attacker capture and replay it. Core now rejects IAM auth when TLS is disabled, failing closed before any token is created or sent (valkey-io/valkey-glide#7397). This bumps the submodule to that fix and upgrades the IAM integration tests to run over TLS.
Issue link
Related: valkey-io/valkey-glide#7023
Changes
valkey-glidesubmodule to the merged core TLS-enforcement fix (b360e69b).iam_configrow now notes TLS is required.Testing
Checklist
git commit -s) per the DCO.bundle exec rubocop) and pass.