-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(gcp_pubsub source): recover from stalled streams and reduce error noise #25901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamyDjemai
wants to merge
13
commits into
vectordotdev:master
Choose a base branch
from
SamyDjemai:fix/gcp-pubsub-stalled-stream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+380
−39
Open
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
63da8be
fix(gcp_pubsub source): recover from stalled streams and reduce error…
SamyDjemai 54108a4
chore(gcp_pubsub source): drop low-value decision unit tests
SamyDjemai 40b224b
enhancement(gcp_pubsub source): align HTTP/2 keepalive with vector si…
SamyDjemai 7e6e1a0
docs(gcp_pubsub source): note configurable keepalive in changelog
SamyDjemai 9a610ca
Merge branch 'master' into fix/gcp-pubsub-stalled-stream
SamyDjemai 8307a03
fix(gcp_pubsub source): address stalled-stream review feedback
SamyDjemai 47479d3
Merge branch 'master' into fix/gcp-pubsub-stalled-stream
SamyDjemai 1f0b4d2
fix(gcp_pubsub source): address second round of review feedback
SamyDjemai d45eddc
fix(gcp_pubsub source): address third round of review feedback
SamyDjemai 5526793
fix(gcp_pubsub source): don't block the select loop on ack sends
SamyDjemai bc31918
fix(gcp_pubsub source): keep reporting fetch errors past the threshold
SamyDjemai 3f992d5
fix(gcp_pubsub source): make the auto-ack send non-blocking too
SamyDjemai a4e78d7
fix(gcp_pubsub source): bound streaming-pull startup with the idle ti…
SamyDjemai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| The `gcp_pubsub` source no longer floods the logs with misleading errors on idle, low-volume, or bursty subscriptions. GCP routinely ends a streaming pull with a transient error (such as an `Unavailable` status when there are simply no messages to deliver), which Vector retries automatically. These transient failures are now logged at `debug`, and a `failed_fetching_events` component error is only emitted once several failures occur in a row without any successful fetch in between. The threshold is configurable via the new `max_retry_errors` option (default `5`); a successful fetch resets the counter. | ||
|
|
||
| The source is also more resilient to connections that silently break and stop delivering messages until Vector is restarted: | ||
|
|
||
| - HTTP/2 keepalive pings are sent on the gRPC connection so a dead-but-open connection is detected and torn down instead of hanging. The ping interval and timeout are configurable via the new `keepalive` option. | ||
| - The stream keepalive uses a non-blocking send, so a backed-up request channel can no longer deadlock the task. | ||
| - A new `idle_timeout_secs` option (defaulting to `900`) restarts the stream if no activity is seen on an active connection within that window. | ||
|
|
||
| authors: SamyDjemai | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.