Repository navigation
changelog: move the Update Changelogs workflow here and fix section headers - #63
Open
KonradBreitsprecherBkd wants to merge 1 commit into
Open
KonradBreitsprecherBkd wants to merge 1 commit into
KonradBreitsprecherBkd wants to merge 1 commit into
Conversation
…eaders
The workflow and changelog_converter.py move from sil-kit-delivery
(update_packaging_changelogs.yml) into sil-kit-pkg. It runs on github.com
next to the files it changes, so it needs no GitHub App token and no hop from
the internal GitHub Enterprise; the pull request is opened with GITHUB_TOKEN.
The converter only takes the bullets of the Keep a Changelog sections (Added,
Changed, Deprecated, Removed, Fixed, Security). Before, a section header was
appended to the previous entry ("... ships one.# Fixed" in 5.0.8), and notes
and tables of other sections could end up in the package changelogs.
tests/test_changelog_converter.py covers this.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Update Changelogs workflow moves from sil-kit-delivery (
update_packaging_changelogs.yml) into this repository, next to the files it changes. It also fixes how section headers are handled. Part 3 of 3, independent of #62 and #64.Workflow
update-changelogs.yml(dispatch) readsdocs/changelog/versions/latest.mdof vectorgrp/sil-kit atsilkit_ref(defaultmain). It adds the entry todebian/changelogandrpm/libsilkit5.spec, pushesupdate_to_<version>and opens a pull request for review.GITHUB_TOKEN. No GitHub App token and no hop from the internal GitHub Enterprise.sil-kit@…,noreply@…) are rejected.Converter fix
Only the bullets of the Keep a Changelog sections (Added, Changed, Deprecated, Removed, Fixed, Security) are taken over.
debian/changelogand the spec ends one item with… that ships one.# Fixed.tests/test_changelog_converter.pycovers this. Run it withpython3 -m unittest discover -s tests -p "test_changelog*.py"; the workflow runs it before converting. A dry run against the real5.0.8.mdgives the expected entries without the stray header.Notes
gh pr createwithGITHUB_TOKEN.GITHUB_TOKENdo not start other workflows. This repository has no PR checks today.🤖 Generated with Claude Code