Skip to content

Fix NPE in Matrix constructors #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LonelyMidoriya wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Fix NPE in Matrix constructors #743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66b57ef
Fix NPE in Matrix constructors
LonelyMidoriya Jul 31, 2026
c5a4397
Update Matrix.java
LonelyMidoriya Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions wcag-validation/src/main/java/org/verapdf/gf/model/factory/chunks/Matrix.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,21 @@

import org.verapdf.cos.COSArray;
import org.verapdf.cos.COSBase;
import org.verapdf.cos.COSObject;
import org.verapdf.wcag.algorithms.entities.geometry.BoundingBox;
import org.verapdf.wcag.algorithms.entities.geometry.Vertex;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;

/**
* @author Maxim Plushchov
*/
public class Matrix implements Cloneable {
private static final Logger LOGGER = Logger.getLogger(Matrix.class.getCanonicalName());

private static final int SIZE = 6;
private double[] matrixArray;
Expand All @@ -47,22 +51,32 @@ public Matrix(double[] src) {

public Matrix(COSArray array) {
matrixArray = new double[SIZE];
matrixArray[0] = array.at(0).getReal();
matrixArray[1] = array.at(1).getReal();
matrixArray[2] = array.at(2).getReal();
matrixArray[3] = array.at(3).getReal();
matrixArray[4] = array.at(4).getReal();
matrixArray[5] = array.at(5).getReal();
for (int i = 0; i < SIZE; i++) {
COSObject arg = array.at(i);
Double d = (arg != null) ? arg.getReal() : null;
if (d == null) {
matrixArray = new double[] {1, 0, 0, 1, 0, 0};
LOGGER.log(Level.WARNING,"Null real value for matrix argument at index {0} in COSArray. " +
"Defaulting to matrix [1,0,0,1,0,0].", i);
return;
}
matrixArray[i] = d;
}
}

public Matrix(List<COSBase> arguments) {
matrixArray = new double[SIZE];
matrixArray[0] = arguments.get(0).getReal();
matrixArray[1] = arguments.get(1).getReal();
matrixArray[2] = arguments.get(2).getReal();
matrixArray[3] = arguments.get(3).getReal();
matrixArray[4] = arguments.get(4).getReal();
matrixArray[5] = arguments.get(5).getReal();
matrixArray = new double[SIZE];
for (int i = 0; i < SIZE; i++) {
COSBase arg = arguments.get(i);
Double d = (arg != null) ? arg.getReal() : null;
if (d == null) {
matrixArray = new double[] {1, 0, 0, 1, 0, 0};
LOGGER.log(Level.WARNING,"Null real value for matrix argument at index {0} in List of arguments. " +
"Defaulting to matrix [1,0,0,1,0,0].", i);
return;
}
matrixArray[i] = d;
}
}

public Matrix(double a, double b, double c, double d, double e, double f) {
Expand Down
Loading