react-view-transitions: plain-prose description for upload validator#244
Open
mvanhorn wants to merge 1 commit intovercel-labs:mainfrom
Open
react-view-transitions: plain-prose description for upload validator#244mvanhorn wants to merge 1 commit intovercel-labs:mainfrom
mvanhorn wants to merge 1 commit intovercel-labs:mainfrom
Conversation
…ator Closes vercel-labs#214. Claude's skill upload validator rejects SKILL.md when the description frontmatter field contains XML tags ("SKILL.md description cannot contain XML tags"). The description had backtick-wrapped XML-style tokens like \`<ViewTransition>\` that the validator treats as XML. Rewrites the offending tokens in plain prose ("the `ViewTransition` component" instead of "`<ViewTransition>` component"), preserving the same intent and trigger phrases. Other places in the SKILL.md that already used the bare component name (`ViewTransition`) are unchanged. Repackaged skills/react-view-transitions.zip from the updated source. Swept all other skills/*/SKILL.md descriptions; none had the same issue.
|
@mvanhorn is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
mvanhorn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #214.
Claude's skill upload validator rejects SKILL.md when the
description:frontmatter contains XML tags ("SKILL.md description cannot contain XML tags"). Thereact-view-transitionsdescription had backtick-wrapped XML-style tokens like`<ViewTransition>`that the validator treats as XML.Change
skills/react-view-transitions/SKILL.md:Same intent, same trigger phrases (the description still mentions
ViewTransition,startViewTransition, transition types, etc.), no</>characters.Repackaged
skills/react-view-transitions.zipfrom the updated source so the published artifact matches.Sweep
Checked every
skills/*/SKILL.mddescription:field; only this one was affected.Note (out of scope for this PR)
If the maintainers want to enforce this at build time, a check in
packages/react-best-practices-build/src/validate.ts(or a sibling skill validator) could reject XML tokens indescription:fields before zipping. Happy to file a follow-up PR if interested.