fix: handle process termination by signal safely on Unix#26
Conversation
…al on Unix This commit fixes a bug where wrapped child processes that are killed by a signal (e.g., SIGINT or SIGKILL) would return a generic error code (`1`) instead of the correct POSIX exit status. On Unix platforms, the exit code is now computed as `128 + signal` using `std::os::unix::process::ExitStatusExt`. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
O PR corrige um problema onde processos finalizados por sinais no Unix (ex:
SIGKILL) retornavam um erro genérico em vez do código de saída POSIX padrão. Retornar128 + sinalpreserva o comportamento esperado e permite que scripts ou shells pai identifiquem corretamente como a execução falhou, agregando muito valor em confiabilidade e experiência de desenvolvimento.O
Makefileque havia sido excluído em um erro foi totalmente restaurado, focando a modificação puramente na melhoria pretendida emsrc/main.rs. A modificação é compilada de forma cross-platform através das macros#[cfg(unix)]e#[cfg(not(unix))].PR created automatically by Jules for task 1023769775584988521 started by @insign