RSDK-14475: pin orientation vector longitude at both poles, not just the north - #188

warning: redundant pattern matching
   --> src/dialdbg/main.rs:391:16
    |
391 |         if let Ok(_) = log_path.try_exists() {
    |                ^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#redundant_pattern_matching
help: consider using `is_ok()`
    |
391 -         if let Ok(_) = log_path.try_exists() {
391 +         if log_path.try_exists().is_ok() {
    |

warning: redundant pattern matching
   --> src/dialdbg/main.rs:318:16
    |
318 |         if let Ok(_) = log_path.try_exists() {
    |                ^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#redundant_pattern_matching
    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
help: consider using `is_ok()`
    |
318 -         if let Ok(_) = log_path.try_exists() {
318 +         if log_path.try_exists().is_ok() {
    |

warning: length comparison to zero
   --> src/dialdbg/main.rs:212:8
    |
212 |     if responses.len() == 0 {
    |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `responses.is_empty()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#len_zero

warning: this function has too many arguments (9/7)
   --> src/dialdbg/main.rs:136:1
    |
136 | / async fn dial_webrtc(
137 | |     uri: &str,
138 | |     credential: &str,
139 | |     credential_type: &str,
...   |
145 | |     disable_mdns: bool,
146 | | ) -> Option<ViamChannel> {
    | |________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: you seem to want to iterate on a map's values
  --> src/dialdbg/stats.rs:49:27
   |
49 |         for (_, value) in &self.0.reports {
   |                           ^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#for_kv_map
   = note: `#[warn(clippy::for_kv_map)]` on by default
help: use the corresponding method
   |
49 -         for (_, value) in &self.0.reports {
49 +         for value in self.0.reports.values() {
   |

warning: length comparison to zero
   --> src/dialdbg/parse.rs:159:8
    |
159 |     if split_log.len() == 0 {
    |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `split_log.is_empty()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#len_zero
    = note: `#[warn(clippy::len_zero)]` on by default

warning: constants have by default a `'static` lifetime
  --> src/dialdbg/parse.rs:10:38
   |
10 | pub(crate) const DIAL_ERROR_PREFIX: &'static str = "unexpected dial connect error";
   |                                     -^^^^^^^---- help: consider removing `'static`: `&str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#redundant_static_lifetimes
   = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default

warning: this multiplication by -1 can be written more succinctly
   --> src/spatialmath/utils.rs:225:43
    |
225 |                 _ => -1.0 * new_x.j.atan2(new_x.i * -1.0),
    |                                           ^^^^^^^^^^^^^^ help: consider using: `-new_x.i`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#neg_multiply

warning: this multiplication by -1 can be written more succinctly
   --> src/spatialmath/utils.rs:225:22
    |
225 |                 _ => -1.0 * new_x.j.atan2(new_x.i * -1.0),
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-new_x.j.atan2(new_x.i * -1.0)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#neg_multiply

warning: this multiplication by -1 can be written more succinctly
   --> src/spatialmath/utils.rs:224:37
    |
224 |                 val if val < 0.0 => -1.0 * new_x.j.atan2(new_x.i),
    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-new_x.j.atan2(new_x.i)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#neg_multiply

warning: this multiplication by -1 can be written more succinctly
   --> src/spatialmath/utils.rs:215:33
    |
215 | ...                   -1.0 * val
    |                       ^^^^^^^^^^ help: consider using: `-val`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#neg_multiply

warning: this multiplication by -1 can be written more succinctly
   --> src/spatialmath/utils.rs:204:79
    |
204 | ...                   UnitQuaternion::from_axis_angle(&new_z_imag_unit, -1.0 * val);
    |                                                                         ^^^^^^^^^^ help: consider using: `-val`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#neg_multiply
    = note: `#[warn(clippy::neg_multiply)]` on by default

warning: redundant reference in `writeln!` argument
    --> src/rpc/dial.rs:1145:13
     |
1145 |             &self.max_duration.as_millis()
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the redundant `&`: `self.max_duration.as_millis()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#useless_borrows_in_formatting

warning: redundant reference in `writeln!` argument
    --> src/rpc/dial.rs:1143:13
     |
1143 |             &self.count,
     |             ^^^^^^^^^^^ help: remove the redundant `&`: `self.count`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#useless_borrows_in_formatting

warning: needlessly taken reference of both operands
    --> src/rpc/dial.rs:1139:32
     |
1139 |         let average_duration = &self.total_duration.as_millis() / &self.count;
     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#op_ref
     = note: `#[warn(clippy::op_ref)]` on by default
help: use the values directly
     |
1139 -         let average_duration = &self.total_duration.as_millis() / &self.count;
1139 +         let average_duration = self.total_duration.as_millis() / self.count;
     |

warning: redundant reference in `format_args!` argument
   --> src/rpc/dial.rs:293:49
    |
293 |             .field("State", &format_args!("{}", &std::any::type_name::<T>()))
    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the redundant `&`: `std::any::type_name::<T>()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#useless_borrows_in_formatting

warning: passing a unit value to a function
   --> src/rpc/client_stream.rs:114:47
    |
114 |             Some(Type::Trailers(trailers)) => Ok(self.process_trailers(trailers.to_owned()).await),
    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#unit_arg
    = note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
    |
114 ~             Some(Type::Trailers(trailers)) => {
115 +                 let _: () = self.process_trailers(trailers.to_owned()).await;
116 +                 Ok(())
117 ~             },
    |

warning: called `unwrap` on `data` after checking its variant with `is_some`
  --> src/rpc/client_stream.rs:27:40
   |
26 |                     if data.is_some() {
   |                     ----------------- help: try: `if let Some(<item>) = data`
27 |                         let mut data = data.unwrap();
   |                                        ^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#unnecessary_unwrap
   = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

warning: redundant reference in `anyhow!` argument
   --> src/rpc/client_channel.rs:146:25
    |
146 |                         &stream.id,
    |                         ^^^^^^^^^^ help: remove the redundant `&`: `stream.id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#useless_borrows_in_formatting

warning: redundant reference in `debug!` argument
  --> src/rpc/client_channel.rs:49:53
   |
49 |         log::debug!("Dropping client channel {:?}", &self);
   |                                                     ^^^^^ help: remove the redundant `&`: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#useless_borrows_in_formatting
   = note: `#[warn(clippy::useless_borrows_in_formatting)]` on by default

warning: doc list item overindented
    --> src/gen/google.api.rs:1932:9
     |
1932 |     ///    if it matches the full pattern specified:
     |         ^^^ help: try using `  ` (2 spaces)
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#doc_overindented_list_items

warning: doc list item overindented
    --> src/gen/google.api.rs:1930:9
     |
1930 |     ///    to the x-goog-request-params routing header.
     |         ^^^ help: try using `  ` (2 spaces)
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#doc_overindented_list_items

warning: doc list item overindented
    --> src/gen/google.api.rs:1929:9
     |
1929 |     ///    and the value matching `instances/*` should be added
     |         ^^^ help: try using `  ` (2 spaces)
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#doc_overindented_list_items

warning: doc list item without indentation
    --> src/gen/google.api.rs:1906:9
     |
1906 |     /// if the match is NOT successful, nothing will be sent.
     |         ^
     |
     = help: if this is supposed to be its own paragraph, add a blank line
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#doc_lazy_continuation
help: indent this line
     |
1906 |     ///   if the match is NOT successful, nothing will be sent.
     |         ++

warning: doc list item without indentation
   --> src/gen/google.api.rs:195:5
    |
195 | ///   request body, all
    |     ^^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#doc_lazy_continuation
help: indent this line
    |
195 | ///      request body, all
    |       +++