Skip to content

test: update registry consumer dependencies from #2598 #2625

Description

@github-actions

Summary

Classification: expected change. The next-react-tailwind registry consumer fails during its production build because @videojs/react/media/hlsjs-video imports @videojs/hlsjs-video, which is not installed in the generated consumer.

Triggering PR

refactor(html): new @videojs/cdn package

Failed run

Evidence

  • The failed job log records a Next.js/Turbopack module-resolution error in packed @videojs/react/dist/default/media/hlsjs-video/media.js: Can't resolve '@videojs/hlsjs-video'.
  • The artifact report was uploaded, but the test-results/trace upload found no files because setup failed before Playwright ran.
  • At the failed SHA, @videojs/react lists @videojs/hlsjs-video in peerDependencies, while the registry package closure in apps/e2e/suites/registry/setup/global.ts follows only dependencies and optionalDependencies.
  • The fixture overlay imports HlsJsVideo from @videojs/react/media/hlsjs-video; PR refactor(html): new @videojs/cdn package #2598 changes CDN paths in page generation but does not add the adapter to this consumer dependency closure.

Likely cause

Verified facts: the consumer uses the HLS.js media component, its adapter is a peer dependency, and that peer is absent from the packed local registry overrides.

Inference: the adapter becoming an explicit peer dependency is intentional; the external-consumer fixture is stale because it does not declare or install the peer required by the media component it exercises.

Recommended actions

  • Update the registry consumer setup or fixture manifest to install/pack @videojs/hlsjs-video when the React HLS.js component is used.
  • Keep the consumer test external to the workspace so it verifies that published package peer requirements are satisfied.
  • Re-run the Registry consumers job and confirm the generated Next consumer builds before evaluating browser assertions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions