Skip to content

fix: NativeHLSTextTracks adopts dash.js text tracks a second time (stack overflow / hang with DASH subtitles) #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
digwa-ing wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: NativeHLSTextTracks adopts dash.js text tracks a second time (stack overflow / hang with DASH subtitles) #1856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/vidstack/src/providers/video/native-hls-text-tracks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@ export class NativeHLSTextTracks {
// Skip tracks the `NativeTextRenderer` has added.
if (!nativeTrack || findTextTrackElement(this.#video, nativeTrack)) return;

// Skip tracks created by a JS playback engine. dash.js adds its text tracks via
// `addTextTrack()` (marked with `manualMode`) and the DASH provider registers them
// from `TEXT_TRACKS_ADDED`; adopting them here as well binds two `TextTrack`s to one
// native track, and the single-showing rule then oscillates against the native
// renderer sync until the call stack overflows (or the page hangs).
if ('manualMode' in nativeTrack) return;
for (const existing of this.#ctx.textTracks) {
if (existing[TextTrackSymbol.native]?.track === nativeTrack) return;
}

const track = new VdsTextTrack({
id: nativeTrack.id,
kind: nativeTrack.kind,
Expand Down