Skip to content

Add unit tests for tooltip summary data and conditional dimension display #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-mears-2 merged 6 commits into from
Jan 19, 2026
Merged

Add unit tests for tooltip summary data and conditional dimension display #32

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6d4c022
Initial plan
Copilot Jan 16, 2026
5cfc536
Initial exploration complete
Copilot Jan 16, 2026
a654ed6
Add tests for new tooltip content (median, mean, 95% CI)
Copilot Jan 16, 2026
7b8abd3
Update tests to verify row dimension display and summary data in tool…
Copilot Jan 16, 2026
05db003
Add assertions to verify row dimension not shown when same as color d…
Copilot Jan 19, 2026
2b95c6a
Update unit tests
david-mears-2 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 89 additions & 5 deletions tests/unit/composables/usePlotTooltips.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import { nextTick } from "vue";
import usePlotTooltips from '@/composables/usePlotTooltips';
import { useAppStore } from '@/stores/appStore';
import { useColorStore } from '@/stores/colorStore';
import { Axis, Dimension, type PointWithMetadata } from '@/types';
import { useDataStore } from '@/stores/dataStore';
import { Axis, Dimension, SummaryTableColumn, type PointWithMetadata, type SummaryTableDataRow } from '@/types';

describe('usePlotTooltips', () => {
beforeEach(() => {
Expand All @@ -28,14 +29,13 @@ describe('usePlotTooltips', () => {
const appStore = useAppStore();
const colorStore = useColorStore();

// Set up store state for location-based coloring
appStore.filters = {
[Dimension.LOCATION]: ['AFG', 'global'],
[Dimension.DISEASE]: ['Cholera'],
};
expect(colorStore.colorDimension).toBe(Dimension.LOCATION);
expect(appStore.dimensions.row).toBe(Dimension.DISEASE);

// Set colors so colorStore has the mapping
colorStore.setColors([afgPointMetadata, globalPointMetadata]);

const { tooltipCallback } = usePlotTooltips();
Expand All @@ -44,12 +44,15 @@ describe('usePlotTooltips', () => {

expect(afgTooltip).toContain('Location: <strong>Afghanistan</strong>');
expect(afgTooltip).toContain('style="color: #009d9a'); // teal50
// Row dimension (disease) is shown because it's different from color dimension (location)
expect(afgTooltip).toContain('Disease: <strong>Cholera</strong>');
expect(afgTooltip).not.toContain('Activity type');

const globalTooltip = tooltipCallback({ x: 1, y: 2, metadata: globalPointMetadata.metadata! });

expect(globalTooltip).toContain('Location: <strong>All 117 VIMC countries</strong>');
expect(globalTooltip).toContain('style="color: #6929c4'); // purple70
expect(globalTooltip).toContain('Disease: <strong>Cholera</strong>');
expect(globalTooltip).not.toContain('Activity type');
});

Expand All @@ -60,12 +63,12 @@ describe('usePlotTooltips', () => {
const appStore = useAppStore();
const colorStore = useColorStore();

// Set up store state for disease-based coloring
appStore.filters = {
[Dimension.LOCATION]: ['AFG'],
[Dimension.DISEASE]: ['Cholera', 'Measles'],
};
expect(colorStore.colorDimension).toBe(Dimension.DISEASE);
expect(appStore.dimensions.row).toBe(Dimension.DISEASE);

colorStore.setColors([choleraPointMetadata, measlesPointMetadata]);

Expand All @@ -75,12 +78,16 @@ describe('usePlotTooltips', () => {

expect(choleraTooltip).toContain('Disease: <strong>Cholera</strong>');
expect(choleraTooltip).toContain('style="color: #6929c4'); // purple70
// Row dimension (disease) is NOT shown separately because it's the same as color dimension
expect(choleraTooltip.match(/Disease:/g)?.length).toBe(1);
expect(choleraTooltip).not.toContain('Activity type');

const measlesTooltip = tooltipCallback({ x: 1, y: 2, metadata: measlesPointMetadata.metadata! });

expect(measlesTooltip).toContain('Disease: <strong>Measles</strong>');
expect(measlesTooltip).toContain('style="color: #009d9a'); // teal50
// Row dimension (disease) is NOT shown separately because it's the same as color dimension
expect(measlesTooltip.match(/Disease:/g)?.length).toBe(1);
expect(measlesTooltip).not.toContain('Activity type');
});

Expand All @@ -95,13 +102,13 @@ describe('usePlotTooltips', () => {
await nextTick();
expect(appStore.dimensions.column).toBe(Dimension.ACTIVITY_TYPE);

// Set up store state for disease-based coloring (single location)
appStore.filters = {
[Dimension.LOCATION]: ['AFG'],
[Dimension.DISEASE]: ['Cholera'],
[Dimension.ACTIVITY_TYPE]: ['routine', 'campaign'],
};
expect(colorStore.colorDimension).toBe(Dimension.DISEASE);
expect(appStore.dimensions.row).toBe(Dimension.DISEASE);

colorStore.setColors([routinePointMetadata, campaignPointMetadata]);

Expand All @@ -110,13 +117,90 @@ describe('usePlotTooltips', () => {
const routineTooltip = tooltipCallback({ x: 1, y: 2, metadata: routinePointMetadata.metadata! });
expect(routineTooltip).toContain('Disease: <strong>Cholera</strong>');
expect(routineTooltip).toContain('Activity type: <strong>Routine</strong>');
// Row dimension (disease) is NOT shown separately because it's the same as color dimension
expect(routineTooltip.match(/Disease:/g)?.length).toBe(1);
expect(routineTooltip).toContain('style="color: #6929c4'); // purple70

const campaignTooltip = tooltipCallback({ x: 1, y: 2, metadata: campaignPointMetadata.metadata! });

expect(campaignTooltip).toContain('Disease: <strong>Cholera</strong>');
expect(campaignTooltip).toContain('Activity type: <strong>Campaign</strong>');
// Row dimension (disease) is NOT shown separately because it's the same as color dimension
expect(campaignTooltip.match(/Disease:/g)?.length).toBe(1);
expect(campaignTooltip).toContain('style="color: #6929c4'); // purple70
});

it('displays summary data (median, mean, and 95% confidence interval) in tooltip', () => {
const afgPointMetadata = { metadata: { [Axis.WITHIN_BAND]: 'AFG', [Axis.ROW]: 'Cholera', [Axis.COLUMN]: '' } };

const appStore = useAppStore();
const colorStore = useColorStore();
const dataStore = useDataStore();

appStore.filters = {
[Dimension.LOCATION]: ['AFG'],
[Dimension.DISEASE]: ['Cholera'],
};

colorStore.setColors([afgPointMetadata]);

dataStore.summaryTableData = [
{
[Dimension.LOCATION]: 'AFG',
[Dimension.DISEASE]: 'Cholera',
[SummaryTableColumn.MEDIAN]: 1234.56,
[SummaryTableColumn.MEAN]: 1456.78,
[SummaryTableColumn.CI_LOWER]: 789.12,
[SummaryTableColumn.CI_UPPER]: 2345.67,
} as SummaryTableDataRow,
];

const { tooltipCallback } = usePlotTooltips();

const tooltip = tooltipCallback({ x: 1, y: 2, metadata: afgPointMetadata.metadata! });

expect(tooltip).toContain('Median: <strong>1234.56</strong>');
expect(tooltip).toContain('Mean: <strong>1456.78</strong>');
expect(tooltip).toContain('95% confidence interval:');
expect(tooltip).toContain('<strong>789.12</strong>');
expect(tooltip).toContain('<strong>2345.67</strong>');
});

it('handles negative confidence interval values with appropriate sign', () => {
const afgPointMetadata = { metadata: { [Axis.WITHIN_BAND]: 'AFG', [Axis.ROW]: 'Cholera', [Axis.COLUMN]: '' } };

const appStore = useAppStore();
const colorStore = useColorStore();
const dataStore = useDataStore();

appStore.filters = {
[Dimension.LOCATION]: ['AFG'],
[Dimension.DISEASE]: ['Cholera'],
};

colorStore.setColors([afgPointMetadata]);

// Set up summary table data with negative lower bound (crossing zero)
dataStore.summaryTableData = [
{
[Dimension.LOCATION]: 'AFG',
[Dimension.DISEASE]: 'Cholera',
[SummaryTableColumn.MEDIAN]: 50.00,
[SummaryTableColumn.MEAN]: 55.00,
[SummaryTableColumn.CI_LOWER]: -100.50,
[SummaryTableColumn.CI_UPPER]: 200.75,
} as SummaryTableDataRow,
];

const { tooltipCallback } = usePlotTooltips();

const tooltip = tooltipCallback({ x: 1, y: 2, metadata: afgPointMetadata.metadata! });

expect(tooltip).toContain('Median: <strong>50.00</strong>');
expect(tooltip).toContain('Mean: <strong>55.00</strong>');
// Check negative lower bound and positive upper bound with + sign when interval crosses zero
expect(tooltip).toContain('<strong>-100.50</strong>');
expect(tooltip).toContain('<strong>+200.75</strong>');
});
});
});