Fix false RedundantCondition for instanceof on a class-string variable#11869
Open
eyupcanakman wants to merge 1 commit into
Open
Fix false RedundantCondition for instanceof on a class-string variable#11869eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
`$x instanceof $class` where `$class` is a `class-string<I>` for an interface `I` was reported as RedundantCondition when `$x` was already `I`. The variable can name any class implementing `I`, so the check can be false at runtime. Interface class-strings now resolve through is_a instead of a fixed type, like is_a($x, $class). Fixes vimeo#11076
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11076
$x instanceof $classwhere$classis aclass-string<I>for an interfaceIwas reported asRedundantConditionwhen$xwas alreadyI. The variable can name any class implementingI, so the check can be false (anArrayIteratoris not aDirectoryIterator, though both areTraversable). Interface class-strings now resolve throughis_ainstead of a fixed type, likeis_a($x, $class)already does.