Fix false positives on a nullable enum property under null coalesce#11878
Open
eyupcanakman wants to merge 1 commit into
Open
Fix false positives on a nullable enum property under null coalesce#11878eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
`$foo->value` (or `->name`) on a nullable enum is treated as always-set under `??`, so psalm emits a false `RedundantCondition` and `TypeDoesNotContainType`. The enum value/name fetch replaced the node type with the case values, which dropped the null a nullable receiver carries inside isset. Real property fetches keep it. The fix combines with the existing node type the same way. Fixes vimeo#11171
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$foo->value(or->name) on a nullable enum is treated as always-set under??, so psalm emits a falseRedundantConditionandTypeDoesNotContainType. The enum value/name fetch replaced the node type with the case values, which dropped the null a nullable receiver carries inside isset. Real property fetches keep it. The fix combines with the existing node type the same way.Fixes #11171