README: document usage accounting, and fix two 404 links - #9
Merged
Merged
Conversation
The README only ever described the TUI. `collect`, `report` and `validate` — the whole accounting side, and the reason the ownership labels exist at all — were not mentioned once, so the config file and the labels it reads were undiscoverable from the front page. Adds a section covering the three subcommands, the label contract (including why `project` is the research project rather than the group code), the config file and its discovery order, and the new `research_projects` spelling check with its real output. Every claim was checked against the code rather than written from memory: the flags come from `--help`, the discovery order from `find_default_config`, each documented config key is one `kmconfig.py` actually parses, and the worked example is real command output. Also fixes the source-install instructions and the build badge, which both pointed at `vios-s/kubmonitor-cli` with a hyphen. The repo is `kubmonitor_cli`; both URLs returned 404. And `-v` is now listed alongside `-V`. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved documentation findings must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This documentation-only PR expands the README with usage-accounting guidance and fixes broken repository links.
Changes:
- Documents commands, labels, configuration, validation, and supporting resources.
- Fixes source-install and build-status URLs.
- Documents the
-vversion flag. - Six unresolved nit findings remain regarding documentation accuracy and completeness.
File summaries
| File | Summary |
|---|---|
README.md |
Adds usage-accounting documentation and corrects installation/status/version references. |
Review details
Suppressed comments (3)
README.md:132
purposeis not required by the validator: missingowner/projectlabels are errors, while missingpurposeonly adds a warning and still returns success. Calling all three labels required contradicts the implemented contract.
| `kubmonitor validate` | Check job YAML carries the required ownership labels — *before* you deploy it. |
README.md:183
- This repeats the unsupported claim that spelling drift splits a project across every report.
report.pydoes not group onresearch_project, so the immediate effect is only two distinct stored values, not two report rows.
With `research_projects` set, `validate` flags a name that looks like a
misspelling of a registered one — the failure mode that quietly splits one
project across two rows in every report:
README.md:165
label_prefixin this project config is not consumed bykubmonitor validate --config; validation still defaults to unprefixed labels and requires the separate--prefixoption. With a non-empty value here, the command shown below will report missing labels, so clarify this distinction or update the validator.
label_prefix: "" # optional: prefix on the three labels
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fix formatting and clarify usage accounting feature in README. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Fix formatting issues in README configuration section. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated YAML configuration with comments for clarity. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You asked whether the README should cover the new configuration. It should — but the gap is bigger than
research_projects.The README only ever described the TUI.
collect,reportandvalidatewere not mentioned once. Someone landing on the front page had no way to discover that usage accounting exists, which also means the ownership labels looked like an unexplained requirement. Documentingresearch_projectsalone would have been a leaf on a tree with no trunk.Added
A Usage Accounting section covering:
owner/project/purposelabel contract, including whyprojectis the research project and not the group code — with themri_reconvsmri-recontrap called out--config→$KUBMONITOR_CONFIG→~/.config/kubmonitor/project.yaml)research_projectsspelling check, with its real output, and the fact that it is advisory and thatvalidatestill works with no configPlus links to
docs/LABELS.mdandexamples/project.yaml, which nothing pointed at before, and the warning to keepmembers.yamlout of public repos.Fixed: two links that 404
The source-install
git cloneand the Build Status badge both used the hyphen. So the documented way to install from source could not have worked for anyone.-vis now listed next to-Vas well.Verified rather than written from memory
--helpoutputfind_default_configkmconfig.pyactually parsesDocs only; no code changes.
🤖 Generated with Claude Code