Fix build issues and parallelize build process#75
Merged
Conversation
All the configuration parts (hashes, env vars, labels) are now closer to each other.
xerpi
approved these changes
Apr 29, 2025
Member
xerpi
left a comment
xerpi
left a comment
There was a problem hiding this comment.
Looks good, thank you very much! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues that were encountered while building locally and in CI.
The build process was parallelized again, so all the tools/libs that don't depend on others are built independently.
The first commit partially reverts #71, since DKP blocks GitHub Actions and I'm guessing some IPs just weren't blocked before, which allowed these changes to work for a some time.
But since the workflows for #74 are failing again, we can assume most of the remaining IPs have been blocked as well.
Some CMake projects refused to build because the CMake version in the image is not backwards compatible with version 3.0 anymore. Forcing to build them anyway works fine, so that's what I opted for.
The ARGS and LABELS have been moved to the top again.
Changes to LABELS don't cause any cache misses and changes to ARGS only cause them on usage, so the cache will only be invalidated from the "checkout" commands onwards.
Note that if there was a cache miss in an earlier image (like buildscripts or libnx) then all the images based on it will also be rebuilt, but that has also been the case before.