fix(dev): apply define constants to worker files in dev mode - #23236
Open
waterWang wants to merge 1 commit into
Open
fix(dev): apply define constants to worker files in dev mode#23236waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
In dev mode, the define plugin skips transforms for all files when
consumer is 'client', relying on the vite client's global injection
for the main thread. However, Web Workers run in a separate global
scope and cannot access the defines injected into the main thread.
This fix detects worker file requests (identified by the
'worker_file' query parameter) and applies the define transform
even in dev mode, ensuring that user-defined constants like
define: { __SOME_CONSTANT__: 128 } are properly replaced in
worker files.
Fixes vitejs#23234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In dev mode, the
definePluginskips transforms for all files whenconsumer is
client, relying on the vite client's global injectionfor the main thread. However, Web Workers run in a separate global
scope and cannot access the defines injected into the main thread.
This fix detects worker file requests (identified by the
worker_filequery parameter) and applies the define transform even in dev mode,
ensuring that user-defined constants like
define: { __SOME_CONSTANT__: 128 }are properly replaced inworker files.
Additional context
Fixes #23234
What is the purpose of this pull request?