Repository navigation
[CI/Build] Move test scripts and assets from .github/ to tests/ (part of #531) - #1024
Conversation
… of vllm-project#531) Moves the 15 loose CI files (curl-*.sh, values-*.yaml, port-forward.sh, template-chatml.jinja) out of .github/ into tests/scripts/ and tests/assets/, and updates all referencing call sites: - .github/workflows/functionality-helm-chart.yml (helm -f, port-forward.sh) - .github/workflows/router-e2e-test.yml (chat-template path) - tests/e2e/run-k8s-routing-test.sh (HELM_VALUES_FILE paths) - tests/scripts/port-forward.sh (curl script path) Also adds tests/assets/** and tests/scripts/** to the path filters of both workflows so changes to the moved files keep triggering CI. No functional changes; pure move + reference updates. Signed-off-by: ighutake-debug <253169138+ighutake-debug@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates the paths in the end-to-end test and port-forwarding scripts to reflect the relocation of test assets and scripts from the .github/ directory to tests/assets/ and tests/scripts/. The review feedback suggests using $(dirname "$0") in port-forward.sh to make the script execution location-independent instead of hardcoding the relative path.
| sleep 5 | ||
|
|
||
| bash ".github/$1.sh" "$ip" "$port" | ||
| bash "tests/scripts/$1.sh" "$ip" "$port" |
There was a problem hiding this comment.
Since port-forward.sh and the target scripts (e.g., curl-*.sh) are now located in the same directory (tests/scripts/), we can avoid hardcoding the relative path tests/scripts/ by using $(dirname "$0"). This makes the script location-independent and allows it to be run successfully from any working directory (including from within tests/scripts/ itself).
| bash "tests/scripts/$1.sh" "$ip" "$port" | |
| bash "$(dirname "$0")/$1.sh" "$ip" "$port" |
|
Hey @ruizhang0101 — PR 1 is up as discussed in #531. Kept it strictly mechanical (pure moves + path updates; every content file is a 100% rename), so review should be quick. The self-hosted e2e jobs will exercise the moved scripts end-to-end on this run — I'll keep an eye on CI and fix anything that shakes out. |
|
Follow-up for the record: the PR-time pre-commit.ci failure appears to have been a service-side runner error — on main, the repo's own pre-commit workflow passes with these changes included, and all four functionality-helm-chart jobs (which exercise the moved values files and port-forward.sh) are green. Nothing outstanding from this PR; @zerofishnoodles happy to adjust anything if you'd like changes in a follow-up. |
|
Status update and a correction:
@zerofishnoodles @ruizhang0101 — could you re-run just the failed Two-Pods job when convenient? Once it goes green, I'd appreciate a review whenever you have a moment. Thanks! |
Implements item 1 ("Move the scripts and assets from
.github/to `tests/") of the CI refactor plan agreed in #531 (comment).Part of #531 — this PR covers only item 1 of 4; follow-up PRs will address the fake-server, job-consolidation, and Helm de-duplication items, so merging this should NOT close the issue.
What changed
Moved 15 loose CI files out of
.github/:tests/scripts/:curl-02-two-pods.sh,curl-04-multiple-models.sh,curl-05-secure-vllm.sh,curl-06-monitoring.sh,port-forward.shtests/assets/:values-01/04/05/06/07/08/09/10/11-*.yaml,template-chatml.jinjaUpdated every referencing call site:
.github/workflows/functionality-helm-chart.yml—helm install -fvalues paths +port-forward.shinvocations.github/workflows/router-e2e-test.yml—--chat-templatepath for the static-discovery backendstests/e2e/run-k8s-routing-test.sh—HELM_VALUES_FILEpaths (10 references)tests/scripts/port-forward.sh— path to the curl scripts it dispatchesAlso added
tests/assets/**andtests/scripts/**to thepathsfilters of both workflows so changes to the moved files keep triggering CI.No functional changes — pure move + reference updates (all 14 content files are 100% renames; only
port-forward.shhas a 1-line path edit).Validation done locally
grepsweep: zero remaining references to the old.github/pathsbash -npasses on all moved/edited shell scriptspre-commit runon all changed files: actionlint, check-yaml, end-of-file, trailing-whitespace, codespell all passThe self-hosted runner jobs (
functionality-helm-chart.yml,router-e2e-test.yml) will exercise the moved scripts end-to-end on this PR's CI run.BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].