Skip to content

[Feat] Support additional sidecar containers and service labels per model - #1044

Open
SSvilen wants to merge 1 commit into
vllm-project:mainfrom
SSvilen:sidecar_container
Open

[Feat] Support additional sidecar containers and service labels per model#1044
SSvilen wants to merge 1 commit into
vllm-project:mainfrom
SSvilen:sidecar_container

Conversation

@SSvilen

@SSvilen SSvilen commented Aug 21, 2026

Copy link
Copy Markdown

Add modelSpec[].extraContainers so users can attach any sidecar container (image, args, env, volumeMounts, livenessProbe, resources, etc.) to a model deployment, independent of enableLoRA. Previously the only sidecar available was the LMCache LoRA sidecar, which is only injected when enableLoRA and pvcStorage are set.

Add modelSpec[].serviceLabels so custom labels, not just annotations, can be applied to the per-model Kubernetes Service.

Update values.yaml, values.schema.json and README.md accordingly.

FILL IN THE PR DESCRIPTION HERE

FIX #xxxx (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

Add modelSpec[].extraContainers so users can attach any sidecar container (image, args, env, volumeMounts, livenessProbe, resources, etc.) to a model deployment, independent of enableLoRA. Previously the only sidecar available was the LMCache LoRA sidecar, which is only injected when enableLoRA and pvcStorage are set.

Add modelSpec[].serviceLabels so custom labels, not just annotations, can be applied to the per-model Kubernetes Service.

Update values.yaml, values.schema.json and README.md accordingly.

Signed-off-by: sultanov_s@outlook.de <sultanov_s@outlook.de>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for configuring additional sidecar containers (extraContainers) in the multi-vLLM deployment and custom labels (serviceLabels) for the model's service. These changes are reflected across the Helm templates, schema validation, default values, and documentation. There are no review comments, and we have no further feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant