-
Notifications
You must be signed in to change notification settings - Fork 485
[Doc] Tutorial 17: troubleshooting the silent-miss preconditions of kvaware routing #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tyler2cr
wants to merge
2
commits into
vllm-project:main
Choose a base branch
from
tyler2cr:tutorial-17-silent-miss-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−0
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter
lmcacheConfig.workerHeartbeatTimeand environment variableLMCACHE_LMCACHE_WORKER_HEARTBEAT_TIMEare not defined in the Helm chart'svalues.yaml. This can be very confusing for users trying to follow the troubleshooting guide. Please update the documentation to use the correct and existing configuration keys for enabling worker heartbeats.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keys do exist and work — they are consumed by the chart rather than declared in
values.yamldefaults:helm/templates/deployment-vllm-multi.yamllines 389–391 renderLMCACHE_LMCACHE_WORKER_HEARTBEAT_TIMEfromlmcacheConfig.workerHeartbeatTimebehind ahasKeyguard, and this tutorial's owntutorials/assets/values-17-kv-aware.yaml(line 28) setsworkerHeartbeatTime: "30". The kernel of truth in this comment is discoverability — the key is absent fromvalues.yaml, which is what made it look nonexistent — so the doc now states that explicitly (added in 8ed05a0). Declaring the key invalues.yamldefaults would be a reasonable chart follow-up.