Skip to content

Add params argument to _get_uuid_by_name - #2071

Open
mslocrian wants to merge 2 commits into
vmware:engfrom
mslocrian:cloud_params_fixups
Open

Add params argument to _get_uuid_by_name#2071
mslocrian wants to merge 2 commits into
vmware:engfrom
mslocrian:cloud_params_fixups

Conversation

@mslocrian

Copy link
Copy Markdown

The delete_by_name() and put_by_name() methods of ApiSession() accept the params argument; however, they do not actually use it in the _get_uuid_by_name() call. This can be problematic if you have two objects with the same name that exist in different clouds.

This PR adds params to those calls and associated methods.

@vmwclabot

Copy link
Copy Markdown

@mslocrian, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot

Copy link
Copy Markdown

@mslocrian, VMware has approved your signed contributor license agreement.

@mslocrian

Copy link
Copy Markdown
Author

@gangaadhars / @chaitanyaavi / @manojkumarjain , where would be the best place to add the test results that the sdk is failing on?

@azizavi
azizavi self-requested a review September 15, 2022 09:01
@aabusair aabusair closed this Aug 31, 2026
@aabusair aabusair reopened this Aug 31, 2026
@aabusair aabusair closed this Aug 31, 2026
@aabusair aabusair reopened this Aug 31, 2026
@legal-compliance-bot

Copy link
Copy Markdown

🛑 Legal Compliance Check Failed

Hi @mslocrian, thank you for your contribution!

To merge this Pull Request, you must sign our DCO.

Note: Even if you signed off your commits locally (using git commit -s), you must post the comment below to register your signature with our automated system.
Note: This is a one-time process. Once signed, future contributions to this repository will be verified automatically.

1. Read the Document: Click here to read the DCO
2. Sign via Comment: Copy and paste the exact line below into a new comment on this Pull Request:

I have read the DCO Document and I hereby sign the DCO for this and all future contributions.

⏳ Processing Schedule:
Our 'Compliance Sweeper' runs automatically approximately every 15-20 minutes.
After you post the comment, your status will update automatically during the next scheduled run.
You do not need to take any further action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants