Repository navigation
Require matching dtypes for extension comparisons - #11016
Open
connortsui20 wants to merge 6 commits into
Open
connortsui20 wants to merge 6 commits into
connortsui20 wants to merge 6 commits into
Conversation
Merging this PR will regress 6 benchmarks1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
connortsui20
marked this pull request as draft
October 29, 2026 22:22
connortsui20
force-pushed
the
ct/ext-types/comparison-consistency
branch
from
October 30, 2026 13:43
2c3048c to
deb59a4
Compare
connortsui20
force-pushed
the
ct/ext-types/comparison-consistency
branch
2 times, most recently
from
October 30, 2026 19:35
b1e9533 to
5bed318
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/ext-types/comparison-consistency
branch
from
October 30, 2026 19:45
5bed318 to
2461528
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extension comparisons could compare raw storage on the array path while scalar execution rejected the same operands. Applies one dtype requirement across comparison paths.
Changes
Checks logical dtypes at binding and before comparison fast paths or encoding kernels run. Regression tests cover batch, row, and constant execution, encoded timestamps, and DuckDB filters. DataFusion literal conversion is handled separately in #11067.
Formatting passes with CI's pinned
nightly-2026-09-10forvortex-datetime-partsandvortex-duckdb. Tests, Clippy, and benchmarks were not rerun locally after cleanup.API Changes
Comparison operands must have matching logical dtypes, ignoring nullability. Comparisons between an extension and its storage dtype, or between different extension dtypes, now return an error. This includes timestamps with different units or time zones.