small tooling issues - #393
Conversation
…solves verilator from TOOLDIR miscs/apptainer/vortex.def omitted libpng-dev and libboost-serialization-dev, which third_party/cocogfx (png.cpp, cgltrace.cpp) requires, so 'make software' fails inside a freshly built image; ci/install_dependencies.sh already installs both. hw/syn/xilinx/xrt/Makefile never included hw/syn/common.mk, so gen_sources.sh fell back to a bare 'verilator' on PATH and failed unless a toolchain env was sourced by hand — the retired toolchain_env.sh used to provide it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
It's possible that the apptainer env was not updated in conjunction to updates in the repo. Aside: I cannot find Standby on this PR, there is some pre-requisite build architecture changes that need to be addressed so incompatibilities don't crop up in the future. I suspect it will be a large undertaking. For now, if you have any bugs feel free to make any local patches and focus on your main project. See: #395 The rework will likely render any minor patches incompatible! |
|
Reviewed and accepted — thank you. Verification
What landed
On the holdThis was held pending #395 (build-architecture rework). I decoupled it: the change is one line in Worth doing in #395 though: generate the apptainer package list from |
miscs/apptainer/vortex.defomittedlibpng-devandlibboost-serialization-dev, whichthird_party/cocogfx(
png.cpp,cgltrace.cpp) needs;make softwarefails inside a freshly built image.ci/install_dependencies.shalready installs both.hw/syn/xilinx/xrt/Makefilenever includedhw/syn/common.mk, sogen_sources.shfell back to a bareverilatoronPATHand failed unless a toolchain env was sourced by hand. Every other synthesis Makefile includes it.