Skip to content

small tooling issues - #393

Closed
ATWeatherly wants to merge 1 commit into
vortexgpgpu:masterfrom
ATWeatherly:fix/build-env-nits
Closed

small tooling issues#393
ATWeatherly wants to merge 1 commit into
vortexgpgpu:masterfrom
ATWeatherly:fix/build-env-nits

Conversation

@ATWeatherly

Copy link
Copy Markdown
Contributor
  • miscs/apptainer/vortex.def omitted libpng-dev and libboost-serialization-dev, which third_party/cocogfx
    (png.cpp, cgltrace.cpp) needs; make software fails inside a freshly built image.
    ci/install_dependencies.sh already installs both.
  • hw/syn/xilinx/xrt/Makefile never included hw/syn/common.mk, so gen_sources.sh fell back to a bare
    verilator on PATH and failed unless a toolchain env was sourced by hand. Every other synthesis Makefile includes it.

…solves verilator from TOOLDIR

miscs/apptainer/vortex.def omitted libpng-dev and libboost-serialization-dev,
which third_party/cocogfx (png.cpp, cgltrace.cpp) requires, so 'make
software' fails inside a freshly built image; ci/install_dependencies.sh
already installs both. hw/syn/xilinx/xrt/Makefile never included
hw/syn/common.mk, so gen_sources.sh fell back to a bare 'verilator' on
PATH and failed unless a toolchain env was sourced by hand — the retired
toolchain_env.sh used to provide it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Udit8348

Copy link
Copy Markdown
Contributor

It's possible that the apptainer env was not updated in conjunction to updates in the repo.

Aside: I cannot find gen_sources.sh file...

Standby on this PR, there is some pre-requisite build architecture changes that need to be addressed so incompatibilities don't crop up in the future. I suspect it will be a large undertaking. For now, if you have any bugs feel free to make any local patches and focus on your main project.

See: #395

The rework will likely render any minor patches incompatible!

@tinebp tinebp closed this in 30d0fe2 Aug 30, 2026
@tinebp

tinebp commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Reviewed and accepted — thank you.

Verification

  • apptainer half — confirmed live on master. miscs/apptainer/vortex.def installs neither
    libpng-dev nor libboost-serialization-dev, while ci/install_dependencies.sh:83 installs
    both and carries a comment saying exactly why (third_party/cocogfxsrc/png.cpp needs
    png.h, src/cgltrace.cpp needs boost/serialization). The definition file and the canonical
    dependency list had simply drifted, so make software fails in a freshly built image.
  • xrt Makefile half — already in-tree. master's hw/syn/xilinx/xrt/Makefile now includes
    hw/syn/common.mk with an explanatory comment; it landed via Gfxw v2 #394. (And to answer the question
    raised in the thread: gen_sources.sh lives at hw/scripts/gen_sources.sh.)

What landed

30d0fe20a on master, authored to you, carrying the apptainer half rebased forward. The xrt
hunk dropped out as already-present, which is why the branch conflicted with master and could not
be updated in place.

On the hold

This was held pending #395 (build-architecture rework). I decoupled it: the change is one line in
miscs/, entirely outside the build-system surface #395 touches, so it creates no rework debt and
there is no reason for a real fresh-image build failure to sit behind a larger refactor.

Worth doing in #395 though: generate the apptainer package list from ci/install_dependencies.sh
instead of hand-mirroring it, so this class of drift stops recurring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants