Skip to content

Improve Handling of sensitive Data - #791

Open
cocker-cc wants to merge 1 commit into
voxpupuli:masterfrom
cocker-cc:Improve_Handling_of_sensitive_Data
Open

cocker-cc wants to merge 1 commit into
voxpupuli:masterfrom
cocker-cc:Improve_Handling_of_sensitive_Data

Conversation

@cocker-cc

Copy link
Copy Markdown
Contributor

Pull Request (PR) description

Remove unneeded unwrap

As soon as Openvox-regsubst flawlessly accepts Sensitive, like Puppet-regsubst does. (PR pending) the original Line in templates/mongoshrc.js.epp can be restored:

    admin.auth('<%= $mongodb::server::config::admin_username %>', '<%= $mongodb::server::config::admin_password.regsubst('\\\\','\\\\\\\\','G').regsubst("'","\\\\'",'G') %>')

@kenyon kenyon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should link to the regsubst PR, otherwise looks good.

Comment thread templates/mongoshrc.js.epp Resolved
@cocker-cc
cocker-cc force-pushed the Improve_Handling_of_sensitive_Data branch from 079f347 to cf5e8cd Compare March 2, 2026 09:14
@kenyon kenyon added the backwards-incompatible This change will lead to a major version bump for the next release label Mar 2, 2026
@cocker-cc
cocker-cc force-pushed the Improve_Handling_of_sensitive_Data branch 2 times, most recently from 139ae57 to 4a6c218 Compare October 22, 2026 07:08
Breaking Change:
Let Function mongodb_password() dynamically react on sensitive Input,
while removing optional Parameter "sensitive".
@cocker-cc
cocker-cc force-pushed the Improve_Handling_of_sensitive_Data branch from 4a6c218 to aae344a Compare October 22, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatible This change will lead to a major version bump for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants