Repository navigation
Conversation
Contributor
|
Wouldn't sensitve be a better way to go? |
Author
That would make sense, looking at the template there isn't a lot more than the aforementioned parameters that should be marked as sensitive. |
Ph0B1uS
force-pushed
the
admin-creds-in-console
branch
from
August 28, 2026 09:20
88ff7b0 to
79be37b
Compare
Ph0B1uS
force-pushed
the
admin-creds-in-console
branch
3 times, most recently
from
September 7, 2026 14:04
20af2a3 to
bc64238
Compare
Author
|
seems like the module does not create the admin user itself and this is why the tests fails. not quite sure how to deal with this but something like this needs to be done with mongosh if the user is not already setup: |
Ph0B1uS
force-pushed
the
admin-creds-in-console
branch
from
November 6, 2026 07:26
61c305a to
6fdcf0e
Compare
Ph0B1uS
force-pushed
the
admin-creds-in-console
branch
from
November 6, 2026 07:32
6fdcf0e to
82eb921
Compare
Author
|
Seems like quite a few tests fail because of the lack of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This removes diffs for
/root/.mongoshrc.jsfrom the console which would leakadmin_usernameandadmin_password.This Pull Request (PR) fixes the following issues
Fixes #798