Fix description of computing pointer-interactable paint tree#1927
Conversation
|
cc @xiaochengh |
|
@whimboo Can you help check this small one too? |
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
Thanks for the fixes. That was indeed broken. Maybe you can take a look at the inline comment?
|
|
||
| <ol> | ||
| <li><p>If <var>element</var> is <a>not in the same tree</a> | ||
| <li><p>If <a><var>element</var></a> is <a>not in the same tree</a> |
There was a problem hiding this comment.
I think that this is correct, bu in other places we use <var><a> so we should be consistent.
But I wonder if we always want to link the element. There are a lot of other instances where we don't do that. So maybe a separate PR fixing all the cases might be good if we wanna have that? But that's not blocking landing this PR.
There was a problem hiding this comment.
That's a good point. Sometimes we call "element element", https://w3c.github.io/webdriver/#dfn-disabled
where the first element links to the Element interface.
For this one, I will just remove the link.
There was a problem hiding this comment.
I have refactored this same way as how we deal with disabled.
Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
This looks good now and matches what we have for An element element is disabled.
Thanks!
SHA: 6bd15e4 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 6bd15e4 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 6bd15e4 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
The step of in-view center point already computes the first object of
getClientRectson element. This PR makes the description more accurate.Preview | Diff