Skip to content

Add safePrintableInset parameter for printing. #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mstensho wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add safePrintableInset parameter for printing. #1950

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1891456
Add safePrintableInset parameter for printing.
mstensho Feb 25, 2026
75e3e5a
Code review
mstensho Feb 27, 2026
7e8f49f
Link to spec
mstensho Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11313,6 +11313,14 @@ <h3><dfn>Print Page</dfn></h3>
<li><p>If <var>shrinkToFit</var> is not a <a>Boolean</a>
return <a>error</a> with <a>error code</a> <a>invalid argument</a>.

<li><p>Let <var>safePrintableInset</var> be the result of <a>getting a
property with default</a> named "<code>safePrintableInset</code>" and with
default <code>0</code> from <var>parameters</var>.
Copy link
Copy Markdown
Contributor

@whimboo whimboo Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only defines the extraction of the safePrintableInset parameter but I do not see how it actually affects printing. So how can WebDriver actually control the right printing behavior of the browser?

I can see in the feature spec that page-margin-safety has the states none | clamp | add, while here a number is used. Will it be added as a paper setting similar to margin?

Copy link
Copy Markdown
Author

@mstensho mstensho Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is used to implement page-margin-safety. I added some spec text now.

For real printers in a real browser, try printing with Margins: Minimum. This is what this value is about. With page-margin-safety, this becomes web-exposed.


<li><p>If <var>safePrintableInset</var> is not a <a>Number</a>, or is a
negative number, return <a>error</a> with <a>error code</a> <a>invalid
argument</a>.

Copy link
Copy Markdown
Contributor

@whimboo whimboo Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets stay in sync with other params and avoid adding line breaks within a definition:

Suggested change
<li><p>If <var>safePrintableInset</var> is not a <a>Number</a>, or is a
negative number, return <a>error</a> with <a>error code</a> <a>invalid
argument</a>.
<li><p>If <var>safePrintableInset</var> is not a <a>Number</a>, or is less then 0, return <a>error</a> with <a>error code</a> <a>invalid argument</a>.

Copy link
Copy Markdown
Author

@mstensho mstensho Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. but not taken verbatim. Less than 0.

<li><p>Let <var>pageRanges</var> be the result of <a>getting a
property with default</a> named "<code>pageRanges</code>" from
<var>parameters</var> with default of an
Expand Down