Repository navigation
Conversation
rustc 1.99 (CI's dtolnay/rust-toolchain@stable) denies invalid_runtime_symbol_definitions: an extern declaration of a symbol the standard library links must match its signature. railgun's npu module declared open(*const u8, i32), so every CI job that builds the workspace (build, test, clippy) fails at railgun on beta. Declare it as libc does, open(*const c_char, i32, ...), and pass a C-string literal. Verified: cargo +1.99.0 and +1.97.1 build --release -p railgun --features npu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustc 1.99, which CI installs through
dtolnay/rust-toolchain@stable, now deniesinvalid_runtime_symbol_definitions: anexterndeclaration of a symbol the standard library itself links must match that symbol's signature.railgun'snpumodule declaredopenwith a non-variadic signature, so every workspace build onbeta(the build, test and clippy jobs) fails atrailgun:Evidence
cargo +1.99.0 build --release --locked -p railgun --features npu, onbeta):3653dd6d3(run 37479462665).cargo +1.99.0andcargo +1.97.1 build --release --locked -p railgun --features npuboth finish.ci.yml.The test job still has red that doesn't come from this change: six tests in
peacemaker-irandhipfire-isarun a hardcoded/opt/rocm/core-10.0/lib/llvm/bin/llvm-mc, which a GitHub runner doesn't have. Theungated_examplesratchet also fails on beta. Neither is touched here.Merge Danger
Door: two-way. The change touches one declaration and its single call site. The ABI is unchanged: the C
openis variadic, and the old declaration simply omitted the variadic part.Blast Radius:
railgunwith thenpufeature only.