Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the documented
hipfire serve --max-seq <N>override and carry it through detached startup, every model load/switch, and multi-slot context sizing. This closes #821.Which surface(s) does this touch?
kernels/,crates/rdna-compute,crates/hipfire-dispatch,crates/hip-bridge,crates/saddle-corecrates/hipfire-loader,crates/hipfire-daemon, runtime load path (model_load,hfq,loader_api,config,safetensors_source,weight_backend,multi_gpu), archload*/weights*/carrier.rs,hipfire-config,hipfire-registry,registry/, Cargo manifestscrates/hipfire-engine,crates/hipfire-generate, daemon slots/serve, runtime emit/eos/dflash/dspark/spec/reset/triattncrates/hipfire-quantize/ quant formatshipfire-cli,hipfire-client,hipfire-tuiBehavior
serve --max-seqthrough the existingmemory.max_seqschema contract.serve --detachlaunches the foreground child.multi_slot_ctx, avoiding a mismatch between advertised context and slot capacity.Test plan
./scripts/no-gpu-ci.shpasses, or the CI jobs are greencargo build --release -p hipfire-clicargo test -p hipfire-cli— 337 passed, 0 failedparams.max_seq=65536on both load operationshipfire serve --helpadvertises--max-seq <N>qwen3.5-0.8b.mq4, Q8 KV,--max-seq 65536; load reportedphysical_cap=65536,/healthreportedn_ctx=65536andmulti_slot_ctx=65536, and a 40,010-prompt-token request completed successfullycargo test --lib --workspacepasses./scripts/speed-gate.shwithin ±2% of locked baselines./scripts/no-gpu-ci.shcompleted its Rust stages, then reported 541 Python tests passed and 21 failed inscripts/hw-gate/tests/test_review.py. The same representative failure was independently reproduced on an unmodified worktree at the parentupstream/betacommit: the localscripts/hw-gate/select.pyshadows Python's standard-libraryselectmodule while importingsubprocess/selectors. This PR does not touch that path, so the checkbox remains unchecked pending upstream CI.This is not performance-relevant and changes no GPU/kernel route.
Architecture-trait change?
No. This does not change
Architectureor any architecture crate.