Repository navigation
feat(vectorIndex): add centered RQ4 quantization support - #468
Open
OsamaAnsar wants to merge 2 commits into
Open
OsamaAnsar wants to merge 2 commits into
OsamaAnsar wants to merge 2 commits into
Conversation
Adds optional centering and trainingLimit fields to the RQ quantizer config (create + reconfigure), matching the shape already merged in weaviate-python-client#2148. No wire/proto changes needed since RQ config is a plain hand-written TS type sent via the REST schema API.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Contributor
Author
|
I agree with the CLA |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #467
Adds
centering?: booleanandtrainingLimit?: numberto the RQ quantizer config, for bothconfigure.vectorIndex.quantizer.rq()(create) andreconfigure.vectorIndex.quantizer.rq()(update).Field shape
Cross-referenced the already-merged Python client implementation (weaviate-python-client#2148) for the exact fields, since the linked server PR (weaviate/weaviate#12502) doesn't expose the REST schema naming directly in its diff.
trainingLimitmatches the naming convention this client already uses for PQ/SQ quantizers.Why this was low-risk
RQ quantizer config is a plain hand-written TS type (
RQConfig) sent through the REST schema API, not a gRPC message — so no protobuf regeneration was needed, unlike some other "add support for X" issues in this repo where the client-side type can't be safely added until the server's proto is vendored in.Testing
rq()builders covering all fields including the two new ones.tsc --noEmit: clean.vitest run src/collections/configure/unit.test.ts: 138/138 passing.